Changeset 256430 in webkit

Timestamp:

Feb 12, 2020 5:16:04 AM (4 years ago)

Author:

clopez@igalia.com

Message:

WebDriver: return invalidSessionID exception if the WebProcess doesn't respond (crashes)
​https://bugs.webkit.org/show_bug.cgi?id=207565

Reviewed by Adrian Perez de Castro.

Report InvalidSessionID if the session connection its not connected.

• WebDriverService.cpp:

(WebDriver::WebDriverService::findSessionOrCompleteWithError):

Location:

trunk/Source/WebDriver

Files:

• ChangeLog (modified) (1 diff)
• WebDriverService.cpp (modified) (1 diff)

trunk/Source/WebDriver/ChangeLog

@@ +1 @@
+2020-02-12  Carlos Alberto Lopez Perez  <clopez@igalia.com>
+
+        WebDriver: return invalidSessionID exception if the WebProcess doesn't respond (crashes)
+        https://bugs.webkit.org/show_bug.cgi?id=207565
+
+        Reviewed by Adrian Perez de Castro.
+
+        Report InvalidSessionID if the session connection its not connected.
+
+        * WebDriverService.cpp:
+        (WebDriver::WebDriverService::findSessionOrCompleteWithError):
+
 2020-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebDriver/WebDriverService.cpp

@@ -515 +515 @@
     if (!m_session || m_session->id() != sessionID) {
         completionHandler(CommandResult::fail(CommandResult::ErrorCode::InvalidSessionID));
+        return false;
+    }
+
+    if (!m_session->isConnected()) {
+        m_session = nullptr;
+        completionHandler(CommandResult::fail(CommandResult::ErrorCode::InvalidSessionID, String("session deleted because of page crash or hang.")));
         return false;
     }