Changeset 256453 in webkit

Timestamp:

Feb 12, 2020 10:47:58 AM (4 years ago)

Author:

Jonathan Bedard

Message:

results.webkit.org: Cache archive content
​https://bugs.webkit.org/show_bug.cgi?id=207589

Reviewed by Aakash Jain.

• resultsdbpy/resultsdbpy/flask_support/util.py:

(cache_for): Add decorator function which sets the cache values on the returned response.

• resultsdbpy/resultsdbpy/view/archive_view.py:

(ArchiveView): Cache archive content client-side for 12 hours.

• resultsdbpy/resultsdbpy/view/archive_view_unittest.py:

(ArchiveViewUnittest.test_file): Verify that archived content is cached.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• resultsdbpy/resultsdbpy/flask_support/util.py (modified) (1 diff)
• resultsdbpy/resultsdbpy/view/archive_view.py (modified) (2 diffs)
• resultsdbpy/resultsdbpy/view/archive_view_unittest.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2020-02-12  Jonathan Bedard  <jbedard@apple.com>
+
+        results.webkit.org: Cache archive content
+        https://bugs.webkit.org/show_bug.cgi?id=207589
+
+        Reviewed by Aakash Jain.
+
+        * resultsdbpy/resultsdbpy/flask_support/util.py:
+        (cache_for): Add decorator function which sets the cache values on the returned response.
+        * resultsdbpy/resultsdbpy/view/archive_view.py:
+        (ArchiveView): Cache archive content client-side for 12 hours.
+        * resultsdbpy/resultsdbpy/view/archive_view_unittest.py:
+        (ArchiveViewUnittest.test_file): Verify that archived content is cached.
+
 2020-02-12  Youenn Fablet  <youenn@apple.com>
 

trunk/Tools/resultsdbpy/resultsdbpy/flask_support/util.py

@@ -115 +115 @@
         return real_method
     return decorator
+
+
+def cache_for(hours=12):
+    def decorator(method):
+        def real_method(self=None, method=method, **kwargs):
+            if self:
+                response = method(self=self, **kwargs)
+            else:
+                response = method(**kwargs)
+            response.headers.add('Cache-Control', f'public,max-age={hours * 60 * 60}')
+            return response
+
+        real_method.__name__ = method.__name__
+        return real_method
+    return decorator

trunk/Tools/resultsdbpy/resultsdbpy/view/archive_view.py

@@ -27 +27 @@
 from resultsdbpy.controller.configuration_controller import configuration_for_query
 from resultsdbpy.controller.suite_controller import time_range_for_query
-from resultsdbpy.flask_support.util import AssertRequest, query_as_kwargs, limit_for_query, boolean_query, query_as_string
+from resultsdbpy.flask_support.util import AssertRequest, boolean_query, cache_for, limit_for_query, query_as_kwargs, query_as_string
 from resultsdbpy.view.site_menu import SiteMenu
 
@@ -63 +63 @@
     @configuration_for_query()
     @time_range_for_query()
+    @cache_for(hours=12)
     def extract(
         self, path=None, format=None,

trunk/Tools/resultsdbpy/resultsdbpy/view/archive_view_unittest.py

@@ -74 +74 @@
         self.assertEqual(response.status_code, 200)
         self.assertEqual(response.text, 'data')
+        self.assertEqual(response.headers.get('Cache-Control'), 'public,max-age=43200')