Changeset 256484 in webkit


Ignore:
Timestamp:
Feb 12, 2020 3:03:35 PM (4 years ago)
Author:
Truitt Savell
Message:

Unreviewed, rolling out r256463.

Caused major flakiness on Mac wk2

Reverted changeset:

"REGRESSION (r255158): http/tests/frame-throttling/raf-
throttle-in-cross-origin-subframe.html is a flaky failure"
​https://bugs.webkit.org/show_bug.cgi?id=206839
​https://trac.webkit.org/changeset/256463

Location:
trunk
Files:
33 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r256478 r256484  
     12020-02-12  Truitt Savell  <tsavell@apple.com>
     2
     3        Unreviewed, rolling out r256463.
     4
     5        Caused major flakiness on Mac wk2
     6
     7        Reverted changeset:
     8
     9        "REGRESSION (r255158): http/tests/frame-throttling/raf-
     10        throttle-in-cross-origin-subframe.html is a flaky failure"
     11        https://bugs.webkit.org/show_bug.cgi?id=206839
     12        https://trac.webkit.org/changeset/256463
     13
    1142020-02-12  Jason Lawrence  <lawrence.j@apple.com>
    215

  • trunk/LayoutTests/fast/animation/css-animation-throttling-lowPowerMode.html

    r256463 r256484  
    2626jsTestIsAsync = true;
    2727
     28if (window.internals)
     29  internals.settings.setRenderingUpdateThrottlingEnabled(true);
     30
    2831const element = document.getElementById("testElement");
    2932element.onanimationstart = function() {

  • trunk/LayoutTests/fast/animation/request-animation-frame-throttle-subframe.html

    r256463 r256484  
    66description("Tests that requestAnimationFrame is throttled in subframes that are outside the viewport");
    77window.jsTestIsAsync = true;
     8
     9if (window.internals)
     10    internals.settings.setRenderingUpdateThrottlingEnabled(true);
    811
    912function checkSubframesThrottled()

  • trunk/LayoutTests/fast/animation/request-animation-frame-throttling-detached-iframe.html

    r256463 r256484  
    66description("Test that requestAnimationFrame gets the right throttling in an iframe when inserted into a document.");
    77jsTestIsAsync = true;
     8
     9if (window.internals)
     10    internals.settings.setRenderingUpdateThrottlingEnabled(true);
    811
    912let i = 0;

  • trunk/LayoutTests/fast/animation/request-animation-frame-throttling-lowPowerMode.html

    r256463 r256484  
    77        window.jsTestIsAsync = true;
    88
    9         if (window.internals)
     9        if (window.internals) {
     10            internals.settings.setRenderingUpdateThrottlingEnabled(true);
    1011            internals.setLowPowerModeEnabled(true);
     12        }
    1113
    1214        var start = null;

  • trunk/LayoutTests/fast/animation/request-animation-frame-throttling-outside-viewport.html

    r256463 r256484  
    77        description("Test that requestAnimationFrame gets the right throttling in an iframe when when it's outside the viewport.");
    88        jsTestIsAsync = true;
     9
     10        if (window.internals)
     11            internals.settings.setRenderingUpdateThrottlingEnabled(true);
    912
    1013        var framesPerSecond = 0;

  • trunk/LayoutTests/http/tests/frame-throttling/raf-throttle-in-cross-origin-subframe.html

    r256463 r256484  
    1414    description("Tests that requestAnimationFrame is throttled in subframes that are cross-origin, and not in same-origin frames");
    1515    window.jsTestIsAsync = true;
     16
     17    if (window.internals)
     18        internals.settings.setRenderingUpdateThrottlingEnabled(true);
    1619
    1720    var crossOriginFrame;

  • trunk/LayoutTests/platform/mac-wk2/TestExpectations

    r256463 r256484  
    941941webkit.org/b/206961 [ Mojave ] media/media-fragments/TC0035.html [ Pass Failure ]
    942942
     943webkit.org/b/206839 http/tests/frame-throttling/raf-throttle-in-cross-origin-subframe.html [ Pass Failure ]
     944
    943945webkit.org/b/207003 tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-overflow.html [ Pass Failure ]
    944946

  • trunk/Source/WebCore/ChangeLog

    r256482 r256484  
     12020-02-12  Truitt Savell  <tsavell@apple.com>
     2
     3        Unreviewed, rolling out r256463.
     4
     5        Caused major flakiness on Mac wk2
     6
     7        Reverted changeset:
     8
     9        "REGRESSION (r255158): http/tests/frame-throttling/raf-
     10        throttle-in-cross-origin-subframe.html is a flaky failure"
     11        https://bugs.webkit.org/show_bug.cgi?id=206839
     12        https://trac.webkit.org/changeset/256463
     13
    1142020-02-12  Yusuke Suzuki  <ysuzuki@apple.com>
    215

  • trunk/Source/WebCore/page/Page.cpp

    r256463 r256484  
    13851385bool Page::renderingUpdateThrottlingEnabled() const
    13861386{
    1387     return !requestedLayoutMilestones().isEmpty();
     1387    return m_settings->renderingUpdateThrottlingEnabled();
     1388}
     1389
     1390void Page::renderingUpdateThrottlingEnabledChanged()
     1391{
     1392    renderingUpdateScheduler().adjustRenderingUpdateFrequency();
    13881393}
    13891394
    … …  
    21402145void Page::addLayoutMilestones(OptionSet<LayoutMilestone> milestones)
    21412146{
    2142     bool oldRenderingUpdateThrottlingEnabled = renderingUpdateThrottlingEnabled();
    21432147    // In the future, we may want a function that replaces m_layoutMilestones instead of just adding to it.
    21442148    m_requestedLayoutMilestones.add(milestones);
    2145     if (!oldRenderingUpdateThrottlingEnabled && renderingUpdateThrottlingEnabled())
    2146         renderingUpdateScheduler().adjustRenderingUpdateFrequency();
    21472149}
    21482150

  • trunk/Source/WebCore/page/Page.h

    r256463 r256484  
    703703
    704704    bool renderingUpdateThrottlingEnabled() const;
     705    void renderingUpdateThrottlingEnabledChanged();
    705706    bool isRenderingUpdateThrottled() const;
    706707    Seconds preferredRenderingUpdateInterval() const;

  • trunk/Source/WebCore/page/Settings.yaml

    r256463 r256484  
    770770  onChange: hiddenPageCSSAnimationSuspensionEnabledChanged
    771771
     772renderingUpdateThrottlingEnabled:
     773  initial: true
     774  onChange: renderingUpdateThrottlingEnabledChanged
     775
    772776storageBlockingPolicy:
    773777  type: SecurityOrigin::StorageBlockingPolicy

  • trunk/Source/WebCore/page/SettingsBase.cpp

    r256463 r256484  
    408408}
    409409
     410void SettingsBase::renderingUpdateThrottlingEnabledChanged()
     411{
     412    if (m_page)
     413        m_page->renderingUpdateThrottlingEnabledChanged();
     414}
     415
    410416void SettingsBase::resourceUsageOverlayVisibleChanged()
    411417{

  • trunk/Source/WebCore/page/SettingsBase.h

    r256463 r256484  
    195195    void hiddenPageDOMTimerThrottlingStateChanged();
    196196    void hiddenPageCSSAnimationSuspensionEnabledChanged();
     197    void renderingUpdateThrottlingEnabledChanged();
    197198    void resourceUsageOverlayVisibleChanged();
    198199    void iceCandidateFilteringEnabledChanged();

  • trunk/Source/WebKit/ChangeLog

    r256477 r256484  
     12020-02-12  Truitt Savell  <tsavell@apple.com>
     2
     3        Unreviewed, rolling out r256463.
     4
     5        Caused major flakiness on Mac wk2
     6
     7        Reverted changeset:
     8
     9        "REGRESSION (r255158): http/tests/frame-throttling/raf-
     10        throttle-in-cross-origin-subframe.html is a flaky failure"
     11        https://bugs.webkit.org/show_bug.cgi?id=206839
     12        https://trac.webkit.org/changeset/256463
     13
    1142020-02-12  Simon Fraser  <simon.fraser@apple.com>
    215

  • trunk/Source/WebKit/Shared/WebPreferences.yaml

    r256463 r256484  
    496496  type: bool
    497497  defaultValue: DEFAULT_HIDDEN_PAGE_CSS_ANIMATION_SUSPENSION_ENABLED
     498
     499RenderingUpdateThrottlingEnabled:
     500  type: bool
     501  defaultValue: true
    498502
    499503LowPowerVideoAudioBufferSizeEnabled:

  • trunk/Source/WebKit/UIProcess/API/C/WKPreferences.cpp

    r256463 r256484  
    13201320}
    13211321
     1322void WKPreferencesSetRenderingUpdateThrottlingEnabled(WKPreferencesRef preferencesRef, bool enabled)
     1323{
     1324    toImpl(preferencesRef)->setRenderingUpdateThrottlingEnabled(enabled);
     1325}
     1326
     1327bool WKPreferencesGetRenderingUpdateThrottlingEnabled(WKPreferencesRef preferencesRef)
     1328{
     1329    return toImpl(preferencesRef)->renderingUpdateThrottlingEnabled();
     1330}
     1331
    13221332void WKPreferencesSetIncrementalRenderingSuppressionTimeout(WKPreferencesRef preferencesRef, double timeout)
    13231333{

  • trunk/Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h

    r256463 r256484  
    307307WK_EXPORT bool WKPreferencesGetHiddenPageCSSAnimationSuspensionEnabled(WKPreferencesRef preferences);
    308308
     309// Defaults to true.
     310WK_EXPORT void WKPreferencesSetRenderingUpdateThrottlingEnabled(WKPreferencesRef preferences, bool enabled);
     311WK_EXPORT bool WKPreferencesGetRenderingUpdateThrottlingEnabled(WKPreferencesRef preferences);
     312
    309313// Defaults to false
    310314WK_EXPORT void WKPreferencesSetSnapshotAllPlugIns(WKPreferencesRef preferencesRef, bool enabled);

  • trunk/Source/WebKitLegacy/mac/ChangeLog

    r256477 r256484  
     12020-02-12  Truitt Savell  <tsavell@apple.com>
     2
     3        Unreviewed, rolling out r256463.
     4
     5        Caused major flakiness on Mac wk2
     6
     7        Reverted changeset:
     8
     9        "REGRESSION (r255158): http/tests/frame-throttling/raf-
     10        throttle-in-cross-origin-subframe.html is a flaky failure"
     11        https://bugs.webkit.org/show_bug.cgi?id=206839
     12        https://trac.webkit.org/changeset/256463
     13
    1142020-02-12  Simon Fraser  <simon.fraser@apple.com>
    215

  • trunk/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h

    r256463 r256484  
    167167#define WebKitHiddenPageDOMTimerThrottlingEnabledPreferenceKey @"WebKitHiddenPageDOMTimerThrottlingEnabled"
    168168#define WebKitHiddenPageCSSAnimationSuspensionEnabledPreferenceKey @"WebKitHiddenPageCSSAnimationSuspensionEnabled"
     169#define WebKitRenderingUpdateThrottlingEnabledPreferenceKey @"WebKitRenderingUpdateThrottlingEnabled"
    169170#define WebKitLowPowerVideoAudioBufferSizeEnabledPreferenceKey @"WebKitLowPowerVideoAudioBufferSizeEnabled"
    170171#define WebKitUseLegacyTextAlignPositionedElementBehaviorPreferenceKey @"WebKitUseLegacyTextAlignPositionedElementBehavior"

  • trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm

    r256463 r256484  
    595595        @NO, WebKitHiddenPageDOMTimerThrottlingEnabledPreferenceKey,
    596596        @YES, WebKitHiddenPageCSSAnimationSuspensionEnabledPreferenceKey,
     597        @YES, WebKitRenderingUpdateThrottlingEnabledPreferenceKey,
    597598        @NO, WebKitLowPowerVideoAudioBufferSizeEnabledPreferenceKey,
    598599       
    … …  
    27972798}
    27982799
     2800- (BOOL)renderingUpdateThrottlingEnabled
     2801{
     2802    return [self _boolValueForKey:WebKitRenderingUpdateThrottlingEnabledPreferenceKey];
     2803}
     2804
     2805- (void)setRenderingUpdateThrottlingEnabled:(BOOL)enabled
     2806{
     2807    [self _setBoolValue:enabled forKey:WebKitRenderingUpdateThrottlingEnabledPreferenceKey];
     2808}
     2809
    27992810- (BOOL)lowPowerVideoAudioBufferSizeEnabled
    28002811{

  • trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h

    r256463 r256484  
    492492- (BOOL)hiddenPageCSSAnimationSuspensionEnabled;
    493493- (void)setHiddenPageCSSAnimationSuspensionEnabled:(BOOL)flag;
     494
     495- (BOOL)renderingUpdateThrottlingEnabled;
     496- (void)setRenderingUpdateThrottlingEnabled:(BOOL)flag;
    494497
    495498- (BOOL)lowPowerVideoAudioBufferSizeEnabled;

  • trunk/Source/WebKitLegacy/mac/WebView/WebView.mm

    r256463 r256484  
    31303130    settings.setHiddenPageDOMTimerThrottlingEnabled([preferences hiddenPageDOMTimerThrottlingEnabled]);
    31313131    settings.setHiddenPageCSSAnimationSuspensionEnabled([preferences hiddenPageCSSAnimationSuspensionEnabled]);
     3132    settings.setRenderingUpdateThrottlingEnabled([preferences renderingUpdateThrottlingEnabled]);
    31323133
    31333134    WebCore::DeprecatedGlobalSettings::setResourceLoadStatisticsEnabled([preferences resourceLoadStatisticsEnabled]);

  • trunk/Source/WebKitLegacy/win/ChangeLog

    r256463 r256484  
     12020-02-12  Truitt Savell  <tsavell@apple.com>
     2
     3        Unreviewed, rolling out r256463.
     4
     5        Caused major flakiness on Mac wk2
     6
     7        Reverted changeset:
     8
     9        "REGRESSION (r255158): http/tests/frame-throttling/raf-
     10        throttle-in-cross-origin-subframe.html is a flaky failure"
     11        https://bugs.webkit.org/show_bug.cgi?id=206839
     12        https://trac.webkit.org/changeset/256463
     13
    1142020-02-12  Said Abou-Hallawa  <said@apple.com>
    215

  • trunk/Source/WebKitLegacy/win/Interfaces/IWebPreferencesPrivate.idl

    r256463 r256484  
    259259    HRESULT setWebSQLEnabled([in] BOOL enabled);
    260260    HRESULT webSQLEnabled([out, retval] BOOL* enabled);
     261    HRESULT setRenderingUpdateThrottlingEnabled([in] BOOL enabled);
     262    HRESULT renderingUpdateThrottlingEnabled([out, retval] BOOL* enabled);
    261263}
    262264

  • trunk/Source/WebKitLegacy/win/WebPreferenceKeysPrivate.h

    r256463 r256484  
    228228
    229229#define WebKitWebSQLEnabledPreferenceKey "WebKitWebSQLEnabled"
     230
     231#define WebKitRenderingUpdateThrottlingEnabledPreferenceKey "WebKitRenderingUpdateThrottlingEnabled"
     232
     233#define WebKitRenderingUpdateThrottlingEnabledPreferenceKey "WebKitRenderingUpdateThrottlingEnabled"

  • trunk/Source/WebKitLegacy/win/WebPreferences.cpp

    r256463 r256484  
    355355    CFDictionaryAddValue(defaults, CFSTR(WebKitWebSQLEnabledPreferenceKey), kCFBooleanFalse);
    356356
     357    CFDictionaryAddValue(defaults, CFSTR(WebKitRenderingUpdateThrottlingEnabledPreferenceKey), kCFBooleanTrue);
     358
    357359    defaultSettings = defaults;
    358360#endif
    … …  
    24712473}
    24722474
     2475HRESULT WebPreferences::renderingUpdateThrottlingEnabled(_Out_ BOOL* enabled)
     2476{
     2477    if (!enabled)
     2478        return E_POINTER;
     2479    *enabled = boolValueForKey(WebKitRenderingUpdateThrottlingEnabledPreferenceKey);
     2480    return S_OK;
     2481}
     2482
     2483HRESULT WebPreferences::setRenderingUpdateThrottlingEnabled(BOOL enabled)
     2484{
     2485    setBoolValue(WebKitRenderingUpdateThrottlingEnabledPreferenceKey, enabled);
     2486    return S_OK;
     2487}
     2488
    24732489HRESULT WebPreferences::allowTopNavigationToDataURLs(_Out_ BOOL* allowAccess)
    24742490{

  • trunk/Source/WebKitLegacy/win/WebPreferences.h

    r256463 r256484  
    304304    virtual HRESULT STDMETHODCALLTYPE webSQLEnabled(_Out_ BOOL*);
    305305    virtual HRESULT STDMETHODCALLTYPE setWebSQLEnabled(BOOL);
     306    virtual HRESULT STDMETHODCALLTYPE renderingUpdateThrottlingEnabled(_Out_ BOOL*);
     307    virtual HRESULT STDMETHODCALLTYPE setRenderingUpdateThrottlingEnabled(BOOL);
    306308
    307309    // IWebPreferencesPrivate8

  • trunk/Source/WebKitLegacy/win/WebView.cpp

    r256463 r256484  
    56165616    settings.setRequestAnimationFrameEnabled(enabled);
    56175617
     5618    hr = prefsPrivate->renderingUpdateThrottlingEnabled(&enabled);
     5619    if (FAILED(hr))
     5620        return hr;
     5621    settings.setRenderingUpdateThrottlingEnabled(enabled);
     5622
    56185623    hr = prefsPrivate->mockScrollbarsEnabled(&enabled);
    56195624    if (FAILED(hr))

  • trunk/Tools/ChangeLog

    r256483 r256484  
     12020-02-12  Truitt Savell  <tsavell@apple.com>
     2
     3        Unreviewed, rolling out r256463.
     4
     5        Caused major flakiness on Mac wk2
     6
     7        Reverted changeset:
     8
     9        "REGRESSION (r255158): http/tests/frame-throttling/raf-
     10        throttle-in-cross-origin-subframe.html is a flaky failure"
     11        https://bugs.webkit.org/show_bug.cgi?id=206839
     12        https://trac.webkit.org/changeset/256463
     13
    1142020-02-12  Jonathan Bedard  <jbedard@apple.com>
    215

  • trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm

    r256463 r256484  
    996996    [preferences setHiddenPageDOMTimerThrottlingEnabled:NO];
    997997    [preferences setHiddenPageCSSAnimationSuspensionEnabled:NO];
     998    [preferences setRenderingUpdateThrottlingEnabled:NO];
    998999    [preferences setRemotePlaybackEnabled:YES];
    9991000

  • trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp

    r256463 r256484  
    802802    prefsPrivate->setServerTimingEnabled(TRUE);
    803803    prefsPrivate->setAspectRatioOfImgFromWidthAndHeightEnabled(TRUE);
     804    prefsPrivate->setRenderingUpdateThrottlingEnabled(FALSE);
    804805    // FIXME: WebGL2
    805806    // FIXME: WebRTC

  • trunk/Tools/WebKitTestRunner/TestController.cpp

    r256463 r256484  
    909909    WKPreferencesSetHiddenPageDOMTimerThrottlingEnabled(preferences, false);
    910910    WKPreferencesSetHiddenPageCSSAnimationSuspensionEnabled(preferences, false);
     911    WKPreferencesSetRenderingUpdateThrottlingEnabled(preferences, false);
    911912
    912913    WKPreferencesSetAcceleratedDrawingEnabled(preferences, m_shouldUseAcceleratedDrawing || options.useAcceleratedDrawing);
Note: See TracChangeset for help on using the changeset viewer.