Changeset 256657 in webkit

Timestamp:

Feb 14, 2020 5:01:04 PM (4 years ago)

Author:

commit-queue@webkit.org

Message:

Fix flaky tests that scroll before first paint
​https://bugs.webkit.org/show_bug.cgi?id=207780

After ​https://bugs.webkit.org/show_bug.cgi?id=207516, a couple of tests are now flaky. This
is because that patch delays first paint until there is enough content to render, and some
of these tests are issuing scroll events on controls before those controls render. To fix
this, we delay issuing the events until after the page loads.

Patch by Ben Nham <Ben Nham> on 2020-02-14
Reviewed by Simon Fraser.

• fast/events/scroll-in-scaled-page-with-overflow-hidden.html:
• fast/scrolling/scroll-container-horizontally.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• fast/events/scroll-in-scaled-page-with-overflow-hidden.html (modified) (2 diffs)
• fast/scrolling/scroll-container-horizontally.html (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2020-02-14  Ben Nham  <nham@apple.com>
+
+        Fix flaky tests that scroll before first paint
+        https://bugs.webkit.org/show_bug.cgi?id=207780
+
+        After https://bugs.webkit.org/show_bug.cgi?id=207516, a couple of tests are now flaky. This
+        is because that patch delays first paint until there is enough content to render, and some
+        of these tests are issuing scroll events on controls before those controls render. To fix
+        this, we delay issuing the events until after the page loads.
+
+        Reviewed by Simon Fraser.
+
+        * fast/events/scroll-in-scaled-page-with-overflow-hidden.html:
+        * fast/scrolling/scroll-container-horizontally.html:
+
 2020-02-14  Truitt Savell  <tsavell@apple.com>
 

trunk/LayoutTests/fast/events/scroll-in-scaled-page-with-overflow-hidden.html

@@ -14 +14 @@
 
 <script>
-    (function() {
+    window.addEventListener('load', function() {
         if (!window.testRunner) {
             debug("This test only works in the test runner.");
@@ -45 +45 @@
             eventSender.mouseScrollBy(0, -5);
         }
-    })();
+    });
 </script>

trunk/LayoutTests/fast/scrolling/scroll-container-horizontally.html

@@ -23 +23 @@
 </div>
 <script>
-  if (window.eventSender && window.testRunner) {
-    testRunner.waitUntilDone();
-    testRunner.dumpAsText();
+  function runTest() {
     eventSender.monitorWheelEvents();
     // Scroll vertically to reach the bottom scrollable container.
@@ -49 +47 @@
         testRunner.notifyDone();
         }); 
-        });
+    });
+  }
+
+  if (window.eventSender && window.testRunner) {
+    testRunner.waitUntilDone();
+    testRunner.dumpAsText();
+    window.addEventListener('load', runTest);
   }
 </script>