Changeset 25668 in webkit


Ignore:
Timestamp:
Sep 20, 2007 1:52:09 AM (17 years ago)
Author:
rwlbuis
Message:

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=15235
Options can not be removed from a Select element with OptGroup's using JavaScript

Remove HTMLOptionElement children against the proper parent node.

Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r25645 r25668  
     12007-09-20  Rob Buis  <buis@kde.org>
     2
     3        Reviewed by Mitz.
     4
     5        Testcase for:
     6        http://bugs.webkit.org/show_bug.cgi?id=15235
     7        Options can not be removed from a Select element with OptGroup's using JavaScript
     8
     9        * fast/forms/option-in-optgroup-removal-expected.txt: Added.
     10        * fast/forms/option-in-optgroup-removal.html: Added.
     11
    1122007-09-19  Kevin McCullough  <kmccullough@apple.com>
    213

  • trunk/WebCore/ChangeLog

    r25661 r25668  
     12007-09-20  Rob Buis  <buis@kde.org>
     2
     3        Reviewed by Mitz.
     4
     5        http://bugs.webkit.org/show_bug.cgi?id=15235
     6        Options can not be removed from a Select element with OptGroup's using JavaScript
     7
     8        Remove HTMLOptionElement children against the proper parent node.
     9
     10        * html/HTMLSelectElement.cpp:
     11        (WebCore::HTMLSelectElement::remove):
     12
    1132007-09-19  John Sullivan  <sullivan@apple.com>
    214

  • trunk/WebCore/html/HTMLSelectElement.cpp

    r25085 r25668  
    237237        return; // ### what should we do ? remove the last item?
    238238
    239     removeChild(items[listIndex], ec);
     239    Element *item = items[listIndex];
     240    ASSERT(item->parentNode());
     241    item->parentNode()->removeChild(item, ec);
    240242    if (!ec)
    241243        setRecalcListItems();
Note: See TracChangeset for help on using the changeset viewer.