Changeset 256833 in webkit
- Timestamp:
- Feb 18, 2020 9:11:21 AM (4 years ago)
- Location:
- trunk/Source/WebKit
- Files:
-
- 10 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebKit/ChangeLog
r256821 r256833 1 2020-02-18 Daniel Bates <dabates@apple.com> 2 3 Rename dispatchDidReceiveEditorStateAfterFocus() to dispatchDidUpdateEditorState() to better describe its purpose 4 https://bugs.webkit.org/show_bug.cgi?id=207865 5 6 Reviewed by Wenson Hsieh. 7 8 Although the iOS implementation bails out unless it was called after WebPageProxy::elementDidFocus() 9 this platform-independent function is actually invoked whenever the UI process receives either 10 an editor state update or a layer tree commit. Renaming this function to better describe its multi- 11 function purpose, which is to allow the UI process a chance to run post-editor update logic. 12 13 * UIProcess/PageClient.h: 14 * UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm: 15 (WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree): 16 * UIProcess/WebPageProxy.cpp: 17 * UIProcess/WebPageProxy.h: 18 * UIProcess/ios/PageClientImplIOS.h: 19 * UIProcess/ios/PageClientImplIOS.mm: 20 (WebKit::PageClientImpl::didUpdateEditorState): 21 (WebKit::PageClientImpl::didReceiveEditorStateUpdateAfterFocus): Deleted. 22 * UIProcess/ios/WKContentViewInteraction.h: 23 * UIProcess/ios/WKContentViewInteraction.mm: 24 (-[WKContentView _didUpdateEditorState]): 25 (-[WKContentView _didReceiveEditorStateUpdateAfterFocus]): Deleted. 26 * UIProcess/ios/WebPageProxyIOS.mm: 27 (WebKit::WebPageProxy::dispatchDidUpdateEditorState): 28 (WebKit::WebPageProxy::dispatchDidReceiveEditorStateAfterFocus): Deleted. 29 1 30 2020-02-17 Wenson Hsieh <wenson_hsieh@apple.com> 2 31 -
trunk/Source/WebKit/UIProcess/PageClient.h
r255992 r256833 401 401 virtual void elementDidBlur() = 0; 402 402 virtual void focusedElementDidChangeInputMode(WebCore::InputMode) = 0; 403 virtual void did ReceiveEditorStateUpdateAfterFocus() = 0;403 virtual void didUpdateEditorState() = 0; 404 404 virtual bool isFocusingElement() = 0; 405 405 virtual bool interpretKeyEvent(const NativeWebKeyboardEvent&, bool isCharEvent) = 0; -
trunk/Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm
r256512 r256833 252 252 253 253 if (layerTreeTransaction.hasEditorState()) 254 m_webPageProxy.dispatchDid ReceiveEditorStateAfterFocus();254 m_webPageProxy.dispatchDidUpdateEditorState(); 255 255 256 256 if (auto milestones = layerTreeTransaction.newlyReachedPaintingMilestones()) -
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
r256745 r256833 6978 6978 { 6979 6979 updateEditorState(editorState); 6980 dispatchDid ReceiveEditorStateAfterFocus();6980 dispatchDidUpdateEditorState(); 6981 6981 } 6982 6982 6983 6983 #if !PLATFORM(IOS_FAMILY) 6984 6984 6985 void WebPageProxy::dispatchDid ReceiveEditorStateAfterFocus()6985 void WebPageProxy::dispatchDidUpdateEditorState() 6986 6986 { 6987 6987 } -
trunk/Source/WebKit/UIProcess/WebPageProxy.h
r256583 r256833 1535 1535 void updateEditorState(const EditorState&); 1536 1536 void scheduleFullEditorStateUpdate(); 1537 void dispatchDid ReceiveEditorStateAfterFocus();1537 void dispatchDidUpdateEditorState(); 1538 1538 1539 1539 #if HAVE(TOUCH_BAR) … … 2085 2085 void focusedElementDidChangeInputMode(WebCore::InputMode); 2086 2086 void didReleaseAllTouchPoints(); 2087 void did ReceiveEditorStateUpdateAfterFocus();2087 void didUpdateEditorState(); 2088 2088 2089 2089 void showInspectorHighlight(const WebCore::Highlight&); -
trunk/Source/WebKit/UIProcess/ios/PageClientImplIOS.h
r255992 r256833 158 158 void elementDidBlur() override; 159 159 void focusedElementDidChangeInputMode(WebCore::InputMode) override; 160 void did ReceiveEditorStateUpdateAfterFocus() override;160 void didUpdateEditorState() override; 161 161 bool isFocusingElement() override; 162 162 void selectionDidChange() override; -
trunk/Source/WebKit/UIProcess/ios/PageClientImplIOS.mm
r255992 r256833 635 635 } 636 636 637 void PageClientImpl::did ReceiveEditorStateUpdateAfterFocus()638 { 639 [m_contentView _did ReceiveEditorStateUpdateAfterFocus];637 void PageClientImpl::didUpdateEditorState() 638 { 639 [m_contentView _didUpdateEditorState]; 640 640 } 641 641 -
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
r256806 r256833 484 484 - (void)_hideContextMenuHintContainer; 485 485 - (void)_didUpdateInputMode:(WebCore::InputMode)mode; 486 - (void)_did ReceiveEditorStateUpdateAfterFocus;486 - (void)_didUpdateEditorState; 487 487 - (void)_hardwareKeyboardAvailabilityChanged; 488 488 - (void)_selectionChanged; -
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
r256806 r256833 5966 5966 } 5967 5967 5968 - (void)_did ReceiveEditorStateUpdateAfterFocus5968 - (void)_didUpdateEditorState 5969 5969 { 5970 5970 [self _updateInitialWritingDirectionIfNecessary]; -
trunk/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm
r256520 r256833 1159 1159 } 1160 1160 1161 void WebPageProxy::dispatchDid ReceiveEditorStateAfterFocus()1161 void WebPageProxy::dispatchDidUpdateEditorState() 1162 1162 { 1163 1163 if (!m_waitingForPostLayoutEditorStateUpdateAfterFocusingElement || m_editorState.isMissingPostLayoutData) 1164 1164 return; 1165 1165 1166 pageClient().did ReceiveEditorStateUpdateAfterFocus();1166 pageClient().didUpdateEditorState(); 1167 1167 m_waitingForPostLayoutEditorStateUpdateAfterFocusingElement = false; 1168 1168 }
Note: See TracChangeset
for help on using the changeset viewer.