Changeset 257155 in webkit
- Timestamp:
- Feb 21, 2020 12:23:43 PM (4 years ago)
- Location:
- trunk/Source/WebKit
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebKit/ChangeLog
r257153 r257155 1 2020-02-21 Wenson Hsieh <wenson_hsieh@apple.com> 2 3 Address post-review feedback in webkit.org/b/207352 4 https://bugs.webkit.org/show_bug.cgi?id=207352 5 6 Reviewed by Brian Weinstein. 7 8 Use m_mainFrame instead of going through Page, and also append the string "\n\n" instead of appending the 9 newline character twice. 10 11 * WebProcess/WebPage/WebPage.cpp: 12 (WebKit::WebPage::getContentsAsString): 13 1 14 2020-02-21 Peng Liu <peng.liu6@apple.com> 2 15 -
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp
r257079 r257155 3447 3447 case ContentAsStringIncludesChildFrames::Yes: { 3448 3448 StringBuilder builder; 3449 for (RefPtr<Frame> frame = &corePage()->mainFrame(); frame; frame = frame->tree().traverseNextRendered()) {3449 for (RefPtr<Frame> frame = m_mainFrame->coreFrame(); frame; frame = frame->tree().traverseNextRendered()) { 3450 3450 if (auto* webFrame = WebFrame::fromCoreFrame(*frame)) { 3451 if (!builder.isEmpty()) { 3452 builder.append('\n'); 3453 builder.append('\n'); 3454 } 3451 if (!builder.isEmpty()) 3452 builder.appendLiteral("\n\n"); 3455 3453 3456 3454 builder.append(webFrame->contentsAsString());
Note: See TracChangeset
for help on using the changeset viewer.