Changeset 257155 in webkit


Ignore:
Timestamp:
Feb 21, 2020 12:23:43 PM (4 years ago)
Author:
Wenson Hsieh
Message:

Address post-review feedback in webkit.org/b/207352
https://bugs.webkit.org/show_bug.cgi?id=207352

Reviewed by Brian Weinstein.

Use m_mainFrame instead of going through Page, and also append the string "\n\n" instead of appending the
newline character twice.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::getContentsAsString):

Location:
trunk/Source/WebKit
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit/ChangeLog

    r257153 r257155  
     12020-02-21  Wenson Hsieh  <wenson_hsieh@apple.com>
     2
     3        Address post-review feedback in webkit.org/b/207352
     4        https://bugs.webkit.org/show_bug.cgi?id=207352
     5
     6        Reviewed by Brian Weinstein.
     7
     8        Use m_mainFrame instead of going through Page, and also append the string "\n\n" instead of appending the
     9        newline character twice.
     10
     11        * WebProcess/WebPage/WebPage.cpp:
     12        (WebKit::WebPage::getContentsAsString):
     13
    1142020-02-21  Peng Liu  <peng.liu6@apple.com>
    215
  • trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp

    r257079 r257155  
    34473447    case ContentAsStringIncludesChildFrames::Yes: {
    34483448        StringBuilder builder;
    3449         for (RefPtr<Frame> frame = &corePage()->mainFrame(); frame; frame = frame->tree().traverseNextRendered()) {
     3449        for (RefPtr<Frame> frame = m_mainFrame->coreFrame(); frame; frame = frame->tree().traverseNextRendered()) {
    34503450            if (auto* webFrame = WebFrame::fromCoreFrame(*frame)) {
    3451                 if (!builder.isEmpty()) {
    3452                     builder.append('\n');
    3453                     builder.append('\n');
    3454                 }
     3451                if (!builder.isEmpty())
     3452                    builder.appendLiteral("\n\n");
    34553453
    34563454                builder.append(webFrame->contentsAsString());
Note: See TracChangeset for help on using the changeset viewer.