Changeset 257622 in webkit

Timestamp:

Feb 28, 2020 12:44:59 AM (4 years ago)

Author:

Nikita Vasilyev

Message:

REGRESSION(r257411): Web Inspector: Can't add a breakpoint by pressing the plus button
​https://bugs.webkit.org/show_bug.cgi?id=208359
<rdar://problem/59870712>

Reviewed by Brian Burg.

In r257411 I added event.stop() (which is a shortcut for event.preventDefault() and
event.stopImmediatePropagation()) to mousedown handler. Calling event.stopImmediatePropagation()
prevented other mousedown event handlers from running.

This patch no longer calls event.stopImmediatePropagation().

• UserInterface/Views/ButtonNavigationItem.js:

(WI.ButtonNavigationItem.prototype._handleMouseDown):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/ButtonNavigationItem.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2020-02-28  Nikita Vasilyev  <nvasilyev@apple.com>
+
+        REGRESSION(r257411): Web Inspector: Can't add a breakpoint by pressing the plus button
+        https://bugs.webkit.org/show_bug.cgi?id=208359
+        <rdar://problem/59870712>
+
+        Reviewed by Brian Burg.
+
+        In r257411 I added event.stop() (which is a shortcut for event.preventDefault() and
+        event.stopImmediatePropagation()) to mousedown handler. Calling event.stopImmediatePropagation()
+        prevented other mousedown event handlers from running.
+
+        This patch no longer calls event.stopImmediatePropagation().
+
+        * UserInterface/Views/ButtonNavigationItem.js:
+        (WI.ButtonNavigationItem.prototype._handleMouseDown):
+
 2020-02-27  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/ButtonNavigationItem.js

@@ -158 +158 @@
     {
         // Clicking on a button should NOT focus on it.
-        event.stop();
+        event.preventDefault();
     }