Changeset 25788 in webkit


Ignore:
Timestamp:
Sep 27, 2007 6:01:42 PM (17 years ago)
Author:
bdash
Message:

2007-09-27 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

Reflected in existing tests.

  • css/html4.css: Changed listboxes to use border-box sizing, to match Firefox, WinIE and apparently also Safari 2.

2007-09-27 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

  • fast/forms/listbox-clip-expected.checksum:
  • fast/forms/listbox-clip-expected.png:
  • fast/forms/listbox-clip-expected.txt:
  • fast/forms/listbox-selection-2.html:
  • fast/forms/select-item-background-clip.html:
  • fast/forms/select-list-box-with-height-expected.checksum:
  • fast/forms/select-list-box-with-height-expected.png:
  • fast/forms/select-list-box-with-height-expected.txt:
  • fast/text/drawBidiText.html:
Location:
trunk
Files:
12 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r25783 r25788  
     12007-09-27  Mitz Pettel  <mitz@webkit.org>
     2
     3        Reviewed by Dave Hyatt.
     4
     5        - updated tests and results for http://bugs.webkit.org/show_bug.cgi?id=15262
     6          REGRESSION: Margin-top:18px is pushing down the multiple select list box outside the div.
     7
     8        * fast/forms/listbox-clip-expected.checksum:
     9        * fast/forms/listbox-clip-expected.png:
     10        * fast/forms/listbox-clip-expected.txt:
     11        * fast/forms/listbox-selection-2.html:
     12        * fast/forms/select-item-background-clip.html:
     13        * fast/forms/select-list-box-with-height-expected.checksum:
     14        * fast/forms/select-list-box-with-height-expected.png:
     15        * fast/forms/select-list-box-with-height-expected.txt:
     16        * fast/text/drawBidiText.html:
     17
    1182007-09-27  Antti Koivisto  <antti@apple.com>
    219

  • trunk/LayoutTests/fast/forms/listbox-clip-expected.checksum

    r19001 r25788  
    1 244469ce5e8f5b033c6d73c7b7fd13d3
     1c8dfb9f2896f50dc201a942d722b4067

  • trunk/LayoutTests/fast/forms/listbox-clip-expected.txt

    r19001 r25788  
    44  RenderBlock {HTML} at (0,0) size 800x600
    55    RenderBody {BODY} at (8,8) size 784x584
    6       RenderListBox {SELECT} at (0,2) size 102x106 [bgcolor=#FFFFFF] [border: (1px inset #808080)]
     6      RenderListBox {SELECT} at (0,2) size 100x106 [bgcolor=#FFFFFF] [border: (1px inset #808080)]
    77      RenderText {#text} at (0,0) size 0x0
    88      RenderText {#text} at (0,0) size 0x0

  • trunk/LayoutTests/fast/forms/listbox-selection-2.html

    r19149 r25788  
    9494    <body onload="test()">
    9595
    96     <select id="sl1" multiple style="height: 105px; border: 10px solid; padding: 5px;">
     96    <select id="sl1" multiple style="height: 135px; border: 10px solid; padding: 5px;">
    9797        <option>one</option>
    9898        <option>two</option>
    … …  
    114114    </select>
    115115   
    116     <select id="sl2" multiple style="height: 105px; border: 10px solid; padding: 5px;">
     116    <select id="sl2" multiple style="height: 135px; border: 10px solid; padding: 5px;">
    117117        <option>one</option>
    118118        <option>two</option>

  • trunk/LayoutTests/fast/forms/select-item-background-clip.html

    r21740 r25788  
    88        REGRESSSION (NativeListBox): Selected option's background is not clipped to the list box</i>.
    99    </p>
    10     <select size="4" style="height: 46px; border: 3px solid blue; padding: 3px;">
     10    <select size="4" style="height: 58px; border: 3px solid blue; padding: 3px;">
    1111        <option>one</option>
    1212        <option>two</option>

  • trunk/LayoutTests/fast/forms/select-list-box-with-height-expected.checksum

    r19001 r25788  
    1 1c8f99de59c167828bd8b3f3080dd11c
     1945ca1438a48ec64890c56ec37ff024f

  • trunk/LayoutTests/fast/forms/select-list-box-with-height-expected.txt

    r18989 r25788  
    77        RenderText {#text} at (0,0) size 365x18
    88          text run at (0,0) width 365: "The select below has a size of 3, but a much larger height."
    9       RenderBlock (anonymous) at (0,34) size 784x252
    10         RenderListBox {SELECT} at (2,0) size 59x252 [bgcolor=#FFFFFF] [border: (1px inset #808080)]
     9      RenderBlock (anonymous) at (0,34) size 784x250
     10        RenderListBox {SELECT} at (2,0) size 59x250 [bgcolor=#FFFFFF] [border: (1px inset #808080)]
    1111        RenderText {#text} at (0,0) size 0x0

  • trunk/WebCore/ChangeLog

    r25785 r25788  
     12007-09-27  Mitz Pettel  <mitz@webkit.org>
     2
     3        Reviewed by Dave Hyatt.
     4
     5        - fix http://bugs.webkit.org/show_bug.cgi?id=15262
     6          REGRESSION: Margin-top:18px is pushing down the multiple select list box outside the div.
     7
     8        Reflected in existing tests.
     9
     10        * css/html4.css: Changed listboxes to use border-box sizing, to match Firefox,
     11        WinIE and apparently also Safari 2.
     12
    1132007-09-27  Kevin Decker  <kdecker@apple.com>
    214

  • trunk/WebCore/css/html4.css

    r25754 r25788  
    460460select[size][multiple] {
    461461    -webkit-appearance: listbox;
    462     -webkit-box-sizing: initial;
    463462    -webkit-box-align: start;
    464463    border: 1px inset gray;
    … …  
    470469select[size="1"] {
    471470    -webkit-appearance: menulist;
    472     -webkit-box-sizing: border-box;
    473471    -webkit-box-align: center;
    474472    border: 1px solid;
Note: See TracChangeset for help on using the changeset viewer.