Changeset 257908 in webkit

Timestamp:

Mar 5, 2020 12:54:49 AM (4 years ago)

Author:

commit-queue@webkit.org

Message:

[JSCOnly] 32-bits warning on memset of JSValue
​https://bugs.webkit.org/show_bug.cgi?id=204411

Patch by Paulo Matos <Paulo Matos> on 2020-03-05
Reviewed by Mark Lam.

Fixes warning on 32bit builds. This is required because GCC knows
it is not safe to use memset on non-POD types and warns against its use.

• heap/GCMemoryOperations.h:

(JSC::gcSafeZeroMemory):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• heap/GCMemoryOperations.h (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2020-03-05  Paulo Matos  <pmatos@igalia.com>
+
+        [JSCOnly] 32-bits warning on memset of JSValue
+        https://bugs.webkit.org/show_bug.cgi?id=204411
+
+        Reviewed by Mark Lam.
+
+        Fixes warning on 32bit builds. This is required because GCC knows
+        it is not safe to use memset on non-POD types and warns against its use.
+
+        * heap/GCMemoryOperations.h:
+        (JSC::gcSafeZeroMemory):
+
 2020-03-04  Mark Lam  <mark.lam@apple.com>
 

trunk/Source/JavaScriptCore/heap/GCMemoryOperations.h

@@ -307 +307 @@
 #endif // COMPILER(GCC_COMPATIBLE)
 #else
-    memset(dst, 0, bytes);
+    memset(reinterpret_cast<char*>(dst), 0, bytes);
 #endif // USE(JSVALUE64)
 }