Changeset 257972 in webkit


Ignore:
Timestamp:
Mar 6, 2020 1:49:53 AM (4 years ago)
Author:
commit-queue@webkit.org
Message:

[WPE][GTK] Use Firefox user agent quirk more aggressively on Google Docs
https://bugs.webkit.org/show_bug.cgi?id=208647

Patch by Michael Catanzaro <Michael Catanzaro> on 2020-03-06
Reviewed by Carlos Garcia Campos.

Source/WebCore:

I had previously determined that we need to send a Firefox user agent quirk to
accounts.youtube.com to avoid unsupported browser warnings on Google Docs. Either the user
agent check has since become more aggressive, or it somehow depends on factors I don't
understand, but as of today it's no longer enough. We now need the quirk for docs.google.com
as well.

  • platform/UserAgentQuirks.cpp:

(WebCore::urlRequiresFirefoxBrowser):

Tools:

  • TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:

(TestWebKitAPI::TEST):

Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r257970 r257972  
     12020-03-06  Michael Catanzaro  <mcatanzaro@gnome.org>
     2
     3        [WPE][GTK] Use Firefox user agent quirk more aggressively on Google Docs
     4        https://bugs.webkit.org/show_bug.cgi?id=208647
     5
     6        Reviewed by Carlos Garcia Campos.
     7
     8        I had previously determined that we need to send a Firefox user agent quirk to
     9        accounts.youtube.com to avoid unsupported browser warnings on Google Docs. Either the user
     10        agent check has since become more aggressive, or it somehow depends on factors I don't
     11        understand, but as of today it's no longer enough. We now need the quirk for docs.google.com
     12        as well.
     13
     14        * platform/UserAgentQuirks.cpp:
     15        (WebCore::urlRequiresFirefoxBrowser):
     16
    1172020-03-05  Zalan Bujtas  <zalan@apple.com>
    218
  • trunk/Source/WebCore/platform/UserAgentQuirks.cpp

    r257139 r257972  
    8686    // on a link to a non-public document that requires signing in. The
    8787    // unsupported browser warning will be displayed after signing in.
    88     if (domain == "accounts.youtube.com")
     88    if (domain == "accounts.youtube.com" || domain == "docs.google.com")
    8989        return true;
    9090
  • trunk/Tools/ChangeLog

    r257963 r257972  
     12020-03-06  Michael Catanzaro  <mcatanzaro@gnome.org>
     2
     3        [WPE][GTK] Use Firefox user agent quirk more aggressively on Google Docs
     4        https://bugs.webkit.org/show_bug.cgi?id=208647
     5
     6        Reviewed by Carlos Garcia Campos.
     7
     8        * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
     9        (TestWebKitAPI::TEST):
     10
    1112020-03-05  Alex Christensen  <achristensen@webkit.org>
    212
  • trunk/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp

    r257139 r257972  
    9393
    9494    assertUserAgentForURLHasFirefoxBrowserQuirk("http://accounts.youtube.com/");
     95    assertUserAgentForURLHasFirefoxBrowserQuirk("http://docs.google.com/");
    9596    assertUserAgentForURLHasFirefoxBrowserQuirk("http://drive.google.com/");
    9697
Note: See TracChangeset for help on using the changeset viewer.