Changeset 257973 in webkit

Timestamp:

Mar 6, 2020 2:02:27 AM (4 years ago)

Author:

Lauro Moura

Message:

[WPE][WebDriver] MiniBrowser should react to close session commands
​https://bugs.webkit.org/show_bug.cgi?id=207529

Reviewed by Carlos Garcia Campos.

Do not call g_object_unref on the first created view if it has already
been disposed in the "close" signal handler.

Based on original patch by Yury Semikhatsky.

• MiniBrowser/wpe/main.cpp:

(main):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• MiniBrowser/wpe/main.cpp (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2020-03-06  Lauro Moura <lmoura@igalia.com>
+
+        [WPE][WebDriver] MiniBrowser should react to close session commands
+        https://bugs.webkit.org/show_bug.cgi?id=207529
+
+        Reviewed by Carlos Garcia Campos.
+
+        Do not call g_object_unref on the first created view if it has already
+        been disposed in the "close" signal handler.
+
+        Based on original patch by Yury Semikhatsky.
+
+        * MiniBrowser/wpe/main.cpp:
+        (main):
+
 2020-03-06  Michael Catanzaro  <mcatanzaro@gnome.org>
 

trunk/Tools/MiniBrowser/wpe/main.cpp

@@ -289 +289 @@
         nullptr));
     g_object_unref(settings);
+    g_object_add_weak_pointer(G_OBJECT(webView), reinterpret_cast<void**>(&webView));
 
     backendPtr->setInputClient(std::make_unique<InputClient>(loop, webView));
@@ -327 +328 @@
     g_main_loop_run(loop);
 
-    g_object_unref(webView);
+    if (webView) {
+        g_object_remove_weak_pointer(G_OBJECT(webView), reinterpret_cast<void**>(&webView));
+        g_object_unref(webView);
+    }
     if (privateMode || automationMode)
         g_object_unref(webContext);