Changeset 258205 in webkit

Timestamp:

Mar 10, 2020 6:56:00 AM (4 years ago)

Author:

eocanha@igalia.com

Message:

REGRESSION(r257977): [GTK] http/tests/media/hls/video-cookie.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=208803

Reviewed by Philippe Normand.

Supply Content-Length, so WebKit GStreamer can actually know when the download has finished
without mistaking EOF with a stall.

• http/tests/media/resources/video-cookie-check-cookie.php: Supply Content-Length.
• platform/gtk/TestExpectations: Removed the test as failing.

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• http/tests/media/resources/video-cookie-check-cookie.php (modified) (1 diff)
• platform/gtk/TestExpectations (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2020-03-10  Enrique Ocaña González  <eocanha@igalia.com>
+
+        REGRESSION(r257977): [GTK] http/tests/media/hls/video-cookie.html is a flaky failure
+        https://bugs.webkit.org/show_bug.cgi?id=208803
+
+        Reviewed by Philippe Normand.
+
+        Supply Content-Length, so WebKit GStreamer can actually know when the download has finished
+        without mistaking EOF with a stall.
+
+        * http/tests/media/resources/video-cookie-check-cookie.php: Supply Content-Length.
+        * platform/gtk/TestExpectations: Removed the test as failing.
+
 2020-03-10  youenn fablet  <youenn@apple.com>
 

trunk/LayoutTests/http/tests/media/resources/video-cookie-check-cookie.php

@@ -17 +17 @@
         header("Cache-Control: no-store");
         header("Connection: close");
+        header("Content-Length: " . filesize($fileName));
 
         $fn = fopen($fileName, "r");

trunk/LayoutTests/platform/gtk/TestExpectations

@@ -2702 +2702 @@
 imported/w3c/web-platform-tests/intersection-observer/v2/cross-origin-occlusion.sub.html [ Missing ]
 
-webkit.org/b/208803 http/tests/media/hls/video-cookie.html [ Failure Pass ]
-
 webkit.org/b/208809 imported/w3c/web-platform-tests/css/WOFF2/blocks-extraneous-data-001.xht [ ImageOnlyFailure Pass ]
 webkit.org/b/208809 imported/w3c/web-platform-tests/css/WOFF2/blocks-extraneous-data-002.xht [ ImageOnlyFailure Pass ]