Changeset 258488 in webkit

Timestamp:

Mar 16, 2020 1:11:26 AM (4 years ago)

Author:

commit-queue@webkit.org

Message:

Remove addHTTPOriginIfNeeded calls
​https://bugs.webkit.org/show_bug.cgi?id=209127

Patch by Rob Buis <​rbuis@igalia.com> on 2020-03-16
Reviewed by Darin Adler.

Remove addHTTPOriginIfNeeded calls since they are get requests and navigations and the spec [1]
indicates that the Origin header should not be written out, making these calls no-ops.

[1] ​https://fetch.spec.whatwg.org/#append-a-request-origin-header

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::changeLocation):
(WebCore::FrameLoader::loadURL):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• loader/FrameLoader.cpp (modified) (6 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-03-16  Rob Buis  <rbuis@igalia.com>
+
+        Remove addHTTPOriginIfNeeded calls
+        https://bugs.webkit.org/show_bug.cgi?id=209127
+
+        Reviewed by Darin Adler.
+
+        Remove addHTTPOriginIfNeeded calls since they are get requests and navigations and the spec [1]
+        indicates that the Origin header should not be written out, making these calls no-ops.
+
+       [1] https://fetch.spec.whatwg.org/#append-a-request-origin-header
+
+        * loader/FrameLoader.cpp:
+        (WebCore::FrameLoader::changeLocation):
+        (WebCore::FrameLoader::loadURL):
+
 2020-03-16  Rob Buis  <rbuis@igalia.com>
 

trunk/Source/WebCore/loader/FrameLoader.cpp

@@ -427 +427 @@
 {
     FRAMELOADER_RELEASE_LOG_IF_ALLOWED(ResourceLoading, "changeLocation: frame load started");
+    ASSERT(frameRequest.resourceRequest().httpMethod() == "GET");
 
     Ref<Frame> protect(m_frame);
@@ -438 +439 @@
         frameRequest.setFrameName(m_frame.document()->baseTarget());
 
-    addHTTPOriginIfNeeded(frameRequest.resourceRequest(), outgoingOrigin());
     m_frame.document()->contentSecurityPolicy()->upgradeInsecureRequestIfNeeded(frameRequest.resourceRequest(), ContentSecurityPolicy::InsecureRequestType::Navigation);
 
@@ -1338 +1338 @@
 {
     FRAMELOADER_RELEASE_LOG_IF_ALLOWED(ResourceLoading, "loadURL: frame load started");
+    ASSERT(frameLoadRequest.resourceRequest().httpMethod() == "GET");
 
     CompletionHandlerCallingScope completionHandlerCaller(WTFMove(completionHandler));
@@ -1357 +1358 @@
         request.setHTTPReferrer(referrer);
         auto referrerOrigin = SecurityOrigin::createFromString(referrer);
-        addHTTPOriginIfNeeded(request, referrerOrigin->toString());
     }
     if (&m_frame.tree().top() != &m_frame)
@@ -4101 +4101 @@
 {
     ASSERT(!features.dialog || request.frameName().isEmpty());
+    ASSERT(request.resourceRequest().httpMethod() == "GET");
 
     created = false;
@@ -4129 +4130 @@
     if (!referrer.isEmpty())
         request.resourceRequest().setHTTPReferrer(referrer);
-    FrameLoader::addHTTPOriginIfNeeded(request.resourceRequest(), openerFrame.loader().outgoingOrigin());
     FrameLoader::addHTTPUpgradeInsecureRequestsIfNeeded(request.resourceRequest());
     FrameLoader::addSameSiteInfoToRequestIfNeeded(request.resourceRequest(), openerFrame.document());