Changeset 258515 in webkit

Timestamp:

Mar 16, 2020 1:11:01 PM (4 years ago)

Author:

pvollan@apple.com

Message:

[Cocoa] Crash under -[WKPreferenceObserver init]
​https://bugs.webkit.org/show_bug.cgi?id=209145

Reviewed by Darin Adler.

Handle the case when calling [NSUserDefaults initWithSuiteName:] did not succeed.

No new tests, since I have not been able to reproduce.

• UIProcess/Cocoa/PreferenceObserver.mm:

(-[WKPreferenceObserver init]):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/Cocoa/PreferenceObserver.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-03-16  Per Arne Vollan  <pvollan@apple.com>
+
+        [Cocoa] Crash under -[WKPreferenceObserver init]
+        https://bugs.webkit.org/show_bug.cgi?id=209145
+
+        Reviewed by Darin Adler.
+
+        Handle the case when calling [NSUserDefaults initWithSuiteName:] did not succeed.
+
+        No new tests, since I have not been able to reproduce.
+
+        * UIProcess/Cocoa/PreferenceObserver.mm:
+        (-[WKPreferenceObserver init]):
+
 2020-03-16  Brent Fulgham  <bfulgham@apple.com>
 

trunk/Source/WebKit/UIProcess/Cocoa/PreferenceObserver.mm

@@ -204 +204 @@
     for (auto domain : domains) {
         auto userDefaults = adoptNS([[WKUserDefaults alloc] initWithSuiteName:domain]);
+        if (!userDefaults) {
+            WTFLogAlways("Could not init user defaults instance for domain %s", String(domain).utf8().data());
+            continue;
+        }
         userDefaults.get()->m_observer = self;
         // Start observing a dummy key in order to make the preference daemon become aware of our NSUserDefaults instance.