Changeset 258562 in webkit

Timestamp:

Mar 17, 2020 11:17:01 AM (4 years ago)

Author:

Chris Dumez

Message:

[WKTR] Crash when trying to open a new window in an ephemeral session test
​https://bugs.webkit.org/show_bug.cgi?id=209181

Reviewed by Geoffrey Garen.

Tools:

Make sure that the new WKWebView is using the same data store as its related WKWebView.

• WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::platformCreateOtherPage):

LayoutTests:

Add layout test coverage.

• fast/dom/window-open-ephemeral-expected.txt: Added.
• fast/dom/window-open-ephemeral.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/dom/window-open-ephemeral-expected.txt (added)
• LayoutTests/fast/dom/window-open-ephemeral.html (added)
• Tools/ChangeLog (modified) (1 diff)
• Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2020-03-17  Chris Dumez  <cdumez@apple.com>
+
+        [WKTR] Crash when trying to open a new window in an ephemeral session test
+        https://bugs.webkit.org/show_bug.cgi?id=209181
+
+        Reviewed by Geoffrey Garen.
+
+        Add layout test coverage.
+
+        * fast/dom/window-open-ephemeral-expected.txt: Added.
+        * fast/dom/window-open-ephemeral.html: Added.
+
 2020-03-16  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Tools/ChangeLog

@@ +1 @@
+2020-03-17  Chris Dumez  <cdumez@apple.com>
+
+        [WKTR] Crash when trying to open a new window in an ephemeral session test
+        https://bugs.webkit.org/show_bug.cgi?id=209181
+
+        Reviewed by Geoffrey Garen.
+
+        Make sure that the new WKWebView is using the same data store as its related WKWebView.
+
+        * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
+        (WTR::TestController::platformCreateOtherPage):
+
 2020-03-17  Jacob Uphoff  <jacob_uphoff@apple.com>
 

trunk/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm

@@ -185 +185 @@
     WKWebViewConfiguration *newConfiguration = [[globalWebViewConfiguration copy] autorelease];
     newConfiguration._relatedWebView = static_cast<WKWebView*>(parentView->platformView());
+    if (newConfiguration._relatedWebView)
+        newConfiguration.websiteDataStore = newConfiguration._relatedWebView.configuration.websiteDataStore;
     PlatformWebView* view = new PlatformWebView(newConfiguration, options);
     finishCreatingPlatformWebView(view, options);