Changeset 258565 in webkit

Timestamp:

Mar 17, 2020 11:33:58 AM (4 years ago)

Author:

ddkilzer@apple.com

Message:

REGRESSION (r258334): WebPasteboardProxy::setPasteboardBufferForType should allow zero-size buffers
<​https://webkit.org/b/209167>
<rdar://problem/60516302>

Reviewed by Geoffrey Garen.

• UIProcess/Cocoa/WebPasteboardProxyCocoa.mm:

(WebKit::WebPasteboardProxy::setPasteboardBufferForType):

• Remove check for zero-size buffer to match WebPageProxy::dataSelectionForPasteboard().

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/Cocoa/WebPasteboardProxyCocoa.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-03-17  David Kilzer  <ddkilzer@apple.com>
+
+        REGRESSION (r258334): WebPasteboardProxy::setPasteboardBufferForType should allow zero-size buffers
+        <https://webkit.org/b/209167>
+        <rdar://problem/60516302>
+
+        Reviewed by Geoffrey Garen.
+
+        * UIProcess/Cocoa/WebPasteboardProxyCocoa.mm:
+        (WebKit::WebPasteboardProxy::setPasteboardBufferForType):
+        - Remove check for zero-size buffer to match
+          WebPageProxy::dataSelectionForPasteboard().
+
 2020-03-17  Brent Fulgham  <bfulgham@apple.com>
 

trunk/Source/WebKit/UIProcess/Cocoa/WebPasteboardProxyCocoa.mm

@@ -185 +185 @@
 
     // SharedMemory::Handle::size() is rounded up to the nearest page.
-    MESSAGE_CHECK(size && size <= handle.size(), completionHandler(0));
+    MESSAGE_CHECK(size <= handle.size(), completionHandler(0));
 
     RefPtr<SharedMemory> sharedMemoryBuffer = SharedMemory::map(handle, SharedMemory::Protection::ReadOnly);