Changeset 258622 in webkit

Timestamp:

Mar 17, 2020 9:14:52 PM (4 years ago)

Author:

Devin Rousso

Message:

Web Inspector: Network: we should prefer showing "Preserve Log" over "Group Media Requests"
​https://bugs.webkit.org/show_bug.cgi?id=209199

Reviewed by Timothy Hatcher.

• UserInterface/Views/NetworkTableContentView.js:

(WI.NetworkTableContentView):
Change the WI.NavigationItem.VisibilityPriority of the various WI.NavigationItem:

High:

• URL filter
• resource type filter
• live/HAR view switcher
• disable resource caching toggle

Normal:

• Preserve Log checkbox
• clear button

Low:

• Group Media Requests checkbox
• HAR import/export buttons

This way, items that have alternate ways of being triggered (e.g. keyboard shortcuts) are
hidden first, and vica versa.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/NetworkTableContentView.js (modified) (4 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2020-03-17  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: Network: we should prefer showing "Preserve Log" over "Group Media Requests"
+        https://bugs.webkit.org/show_bug.cgi?id=209199
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Views/NetworkTableContentView.js:
+        (WI.NetworkTableContentView):
+        Change the `WI.NavigationItem.VisibilityPriority` of the various `WI.NavigationItem`:
+          High:
+           - URL filter
+           - resource type filter
+           - live/HAR view switcher
+           - disable resource caching toggle
+          Normal:
+           - Preserve Log checkbox
+           - clear button
+          Low:
+           - Group Media Requests checkbox
+           - HAR import/export buttons
+        This way, items that have alternate ways of being triggered (e.g. keyboard shortcuts) are
+        hidden first, and vica versa.
+
 2020-03-17  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js

@@ -89 +89 @@
 
         this._typeFilterScopeBar = new WI.ScopeBar("network-type-filter-scope-bar", typeFilterScopeBarItems, typeFilterScopeBarItems[0]);
+        this._typeFilterScopeBar.visibilityPriority = WI.NavigationItem.VisibilityPriority.High;
         this._typeFilterScopeBar.addEventListener(WI.ScopeBar.Event.SelectionChanged, this._typeFilterScopeBarSelectionChanged, this);
 
         if (WI.MediaInstrument.supported()) {
             this._groupMediaRequestsByDOMNodeNavigationItem = new WI.CheckboxNavigationItem("group-media-requests", WI.UIString("Group Media Requests"), WI.settings.groupMediaRequestsByDOMNode.value);
+            this._groupMediaRequestsByDOMNodeNavigationItem.visibilityPriority = WI.NavigationItem.VisibilityPriority.Low;
             this._groupMediaRequestsByDOMNodeNavigationItem.addEventListener(WI.CheckboxNavigationItem.Event.CheckedDidChange, this._handleGroupMediaRequestsByDOMNodeCheckedDidChange, this);
         } else
@@ -102 +104 @@
 
         this._urlFilterNavigationItem = new WI.FilterBarNavigationItem;
+        this._urlFilterNavigationItem.visibilityPriority = WI.NavigationItem.VisibilityPriority.High;
         this._urlFilterNavigationItem.filterBar.addEventListener(WI.FilterBar.Event.FilterDidChange, this._urlFilterDidChange, this);
         this._urlFilterNavigationItem.filterBar.placeholder = WI.UIString("Filter Full URL");
@@ -138 +141 @@
 
         this._checkboxesNavigationItemGroup = new WI.GroupNavigationItem([this._clearOnLoadNavigationItem, new WI.DividerNavigationItem]);
-        this._checkboxesNavigationItemGroup.visibilityPriority = WI.NavigationItem.VisibilityPriority.Low;
 
         this._pathComponentsNavigationItemGroup = new WI.GroupNavigationItem([this._collectionsPathNavigationItem, new WI.DividerNavigationItem]);
-        this._pathComponentsNavigationItemGroup.visibilityPriority = WI.NavigationItem.VisibilityPriority.Low;
+        this._pathComponentsNavigationItemGroup.visibilityPriority = WI.NavigationItem.VisibilityPriority.High;
         this._pathComponentsNavigationItemGroup.hidden = true;
 
@@ -153 +155 @@
             this._disableResourceCacheNavigationItem = new WI.ActivateButtonNavigationItem("disable-resource-cache", toolTipForDisableResourceCache, activatedToolTipForDisableResourceCache, "Images/IgnoreCaches.svg", 16, 16);
             this._disableResourceCacheNavigationItem.activated = WI.settings.resourceCachingDisabled.value;
-
+            this._disableResourceCacheNavigationItem.visibilityPriority = WI.NavigationItem.VisibilityPriority.High;
             this._disableResourceCacheNavigationItem.addEventListener(WI.ButtonNavigationItem.Event.Clicked, this._toggleDisableResourceCache, this);
+
             WI.settings.resourceCachingDisabled.addEventListener(WI.Setting.Event.Changed, this._resourceCachingDisabledSettingChanged, this);
         }