Changeset 258634 in webkit


Ignore:
Timestamp:
Mar 18, 2020 8:26:51 AM (4 years ago)
Author:
commit-queue@webkit.org
Message:

animations/animation-direction-reverse.html is flaky failing
​https://bugs.webkit.org/show_bug.cgi?id=206671
<rdar://problem/58838216>

Patch by Antoine Quint <Antoine Quint> on 2020-03-18
Reviewed by Antti Koivisto.

To make this test robust we animate a non-accelerated property.

  • animations/animation-direction-reverse-expected.txt:
  • animations/animation-direction-reverse.html:
  • platform/ios/TestExpectations:
  • platform/mac/TestExpectations:
Location:
trunk/LayoutTests
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r258632 r258634  
     12020-03-18  Antoine Quint  <graouts@apple.com>
     2
     3        animations/animation-direction-reverse.html is flaky failing
     4        https://bugs.webkit.org/show_bug.cgi?id=206671
     5        <rdar://problem/58838216>
     6
     7        Reviewed by Antti Koivisto.
     8
     9        To make this test robust we animate a non-accelerated property.
     10
     11        * animations/animation-direction-reverse-expected.txt:
     12        * animations/animation-direction-reverse.html:
     13        * platform/ios/TestExpectations:
     14        * platform/mac/TestExpectations:
     15
    1162020-03-18  Eric Carlson  <eric.carlson@apple.com>
    217

  • trunk/LayoutTests/animations/animation-direction-reverse-expected.txt

    r200047 r258634  
    1 PASS - "webkitTransform" property for "box" element at 0.5s saw something close to: 1,0,0,1,150,0
    2 PASS - "webkitTransform" property for "box" element at 1s saw something close to: 1,0,0,1,100,0
    3 PASS - "webkitTransform" property for "box" element at 2.5s saw something close to: none
     1PASS - "margin-left" property for "box" element at 0.5s saw something close to: 150
     2PASS - "margin-left" property for "box" element at 1s saw something close to: 100
     3PASS - "margin-left" property for "box" element at 2.5s saw something close to: 0
    44

  • trunk/LayoutTests/animations/animation-direction-reverse.html

    r200047 r258634  
    2222    }
    2323    @-webkit-keyframes "move1" {
    24       from { -webkit-transform: translateX(0px); }
    25       to   { -webkit-transform: translateX(200px); }
     24      from { margin-left: 0px; }
     25      to   { margin-left: 200px; }
    2626    }
    2727    #result {
    … …  
    3333    const expectedValues = [
    3434      // [animation-name, time, element-id, property, expected-value, tolerance]
    35       ["move1", 0.5, "box", "webkitTransform", [1,0,0,1, 150,0], 20],
    36       ["move1", 1.0, "box", "webkitTransform", [1,0,0,1,100,0], 20],
    37       ["move1", 2.5, "box", "webkitTransform", 'none', 20],
     35      ["move1", 0.5, "box", "margin-left", 150, 20],
     36      ["move1", 1.0, "box", "margin-left", 100, 20],
     37      ["move1", 2.5, "box", "margin-left", 0, 20],
    3838    ];
    3939

  • trunk/LayoutTests/platform/ios/TestExpectations

    r258576 r258634  
    34053405webkit.org/b/206864 http/tests/workers/service/basic-timeout.https.html [ Pass Failure ]
    34063406
    3407 
    3408 webkit.org/b/206671 [ Debug ] animations/animation-direction-reverse.html [ Pass Failure ]
    3409 
    34103407webkit.org/b/206754 imported/w3c/web-platform-tests/css/css-backgrounds/background-image-centered-with-border-radius.html [ ImageOnlyFailure ]
    34113408webkit.org/b/206754 imported/w3c/web-platform-tests/css/css-backgrounds/box-shadow-body.html [ ImageOnlyFailure ]

  • trunk/LayoutTests/platform/mac/TestExpectations

    r258627 r258634  
    19141914webkit.org/b/206685 animations/animation-direction-normal.html [ Pass Failure ]
    19151915
    1916 webkit.org/b/206671 animations/animation-direction-reverse.html [ Pass Failure ]
    1917 
    19181916webkit.org/b/206711 http/wpt/resource-timing/rt-resource-errors.html [ Pass Failure ]
    19191917
Note: See TracChangeset for help on using the changeset viewer.