Changeset 258636 in webkit


Ignore:
Timestamp:
Mar 18, 2020 8:31:18 AM (4 years ago)
Author:
aakash_jain@apple.com
Message:

Remove status-bubble iframe from old EWS
​https://bugs.webkit.org/show_bug.cgi?id=209215

Reviewed by Jonathan Bedard.

  • code-review.js:
  • js/status-bubble.js:

(handleStatusBubbleLoadNewEWS): Deleted.

  • template/en/default/attachment/edit.html.tmpl: Removed old EWS iframe.
  • template/en/default/attachment/list.html.tmpl: Ditto.
  • template/en/default/attachment/reviewform.html.tmpl: Ditto.
Location:
trunk/Websites/bugs.webkit.org
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/Websites/bugs.webkit.org/ChangeLog

    r252167 r258636  
     12020-03-17  Aakash Jain  <aakash_jain@apple.com>
     2
     3        Remove status-bubble iframe from old EWS
     4        https://bugs.webkit.org/show_bug.cgi?id=209215
     5
     6        Reviewed by Jonathan Bedard.
     7
     8        * code-review.js:
     9        * js/status-bubble.js:
     10        (handleStatusBubbleLoadNewEWS): Deleted.
     11        * template/en/default/attachment/edit.html.tmpl: Removed old EWS iframe.
     12        * template/en/default/attachment/list.html.tmpl: Ditto.
     13        * template/en/default/attachment/reviewform.html.tmpl: Ditto.
     14
    1152019-11-06  James Savage  <james.savage@apple.com>
    216

  • trunk/Websites/bugs.webkit.org/code-review.js

    r249483 r258636  
    569569
    570570      var statusBubble = document.createElement('iframe');
    571       statusBubble.src  = 'https://webkit-queues.webkit.org/status-bubble/' + attachment_id;
     571      statusBubble.src  = 'https://ews.webkit.org/status-bubble/' + attachment_id + '?hide_icons=True';
    572572      statusBubble.scrolling = 'no';
    573573      // Can't append the HTML because we need to set the onload handler before appending the iframe to the DOM.
    574574      statusBubble.onload = function () { handleStatusBubbleLoad(this); };
    575575      $('.statusBubble').append(statusBubble);
    576 
    577       var statusBubbleNewEWS = document.createElement('iframe');
    578       statusBubbleNewEWS.src  = 'https://ews.webkit.org/status-bubble/' + attachment_id + '?hide_icons=True';
    579       // Can't append the HTML because we need to set the onload handler before appending the iframe to the DOM.
    580       statusBubbleNewEWS.scrolling = "no";
    581       statusBubbleNewEWS.onload = function () { handleStatusBubbleLoadNewEWS(this); };
    582       $('.statusBubble').append(statusBubbleNewEWS);
    583576
    584577      $('#toolbar .bugLink').html('<a href="/show_bug.cgi?id=' + bug_id + '" target="_blank">Bug ' + bug_id + '</a>');

  • trunk/Websites/bugs.webkit.org/js/status-bubble.js

    r243921 r258636  
    2626
    2727function handleStatusBubbleMessage(event) {
    28     if ((event.origin !== 'https://webkit-queues.webkit.org' && event.origin !== 'https://ews.webkit.org') || !event.data.height)
     28    if (event.origin !== 'https://ews.webkit.org' || !event.data.height)
    2929        return;
    3030
    … …  
    3939
    4040function handleStatusBubbleLoad(iframe) {
    41     iframe.contentWindow.postMessage('containerMetrics', 'https://webkit-queues.webkit.org');
    42 }
    43 
    44 function handleStatusBubbleLoadNewEWS(iframe) {
    4541    iframe.contentWindow.postMessage('containerMetrics', 'https://ews.webkit.org');
    4642}

  • trunk/Websites/bugs.webkit.org/template/en/default/attachment/edit.html.tmpl

    r249483 r258636  
    265265
    266266        <div class="statusBubble">
    267           <iframe src="https://webkit-queues.webkit.org/status-bubble/[% attachment.id %]"
     267          <iframe src="https://ews.webkit.org/status-bubble/[% attachment.id %]?hide_icons=True"
    268268                  style="width: 0px; height: 20px; border: none;" scrolling="no" onload="handleStatusBubbleLoad(this)">
    269           </iframe>
    270           <iframe src="https://ews.webkit.org/status-bubble/[% attachment.id %]?hide_icons=True"
    271                   style="width: 0px; height: 20px; border: none;" scrolling="no" onload="handleStatusBubbleLoadNewEWS(this)">
    272269          </iframe>
    273270        </div>

  • trunk/Websites/bugs.webkit.org/template/en/default/attachment/list.html.tmpl

    r243921 r258636  
    156156          [% IF attachment.ispatch %]
    157157          <div class="statusBubble">
    158             <iframe src="https://webkit-queues.webkit.org/status-bubble/[% attachment.id %]"
     158            <iframe src="https://ews.webkit.org/status-bubble/[% attachment.id %]/"
    159159                    style="width: 0px; height: 20px; border: none;" scrolling="no" onload="handleStatusBubbleLoad(this)">
    160             </iframe>
    161             <iframe src="https://ews.webkit.org/status-bubble/[% attachment.id %]/"
    162                     style="width: 0px; height: 20px; border: none;" scrolling="no" onload="handleStatusBubbleLoadNewEWS(this)">
    163160            </iframe>
    164161          </div>

  • trunk/Websites/bugs.webkit.org/template/en/default/attachment/reviewform.html.tmpl

    r249483 r258636  
    104104    <td>
    105105      <div class="statusBubble" style="margin-left: 30px;">
    106         <iframe src="https://webkit-queues.webkit.org/status-bubble/[% attachment.id %]"
    107                 style="width: 400px; height: 20px; border: none;" scrolling="no">
    108         </iframe>
    109106        <iframe src="https://ews.webkit.org/status-bubble/[% attachment.id %]?hide_icons=True"
    110107                style="width: 700px; height: 20px; border: none;" scrolling="no">
Note: See TracChangeset for help on using the changeset viewer.