Changeset 258639 in webkit


Ignore:
Timestamp:
Mar 18, 2020 8:59:03 AM (4 years ago)
Author:
graouts@webkit.org
Message:

[macOS iOS ] animations/animation-direction-normal.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=206685
<rdar://problem/58841791>

Reviewed by Antti Koivisto.

To make this test robust we animate a non-accelerated property and we use the Web Animations API to set the time
at which we want to pause the animation (2.5s).

  • animations/animation-direction-normal-expected.txt:
  • animations/animation-direction-normal.html:
  • platform/ios-wk2/TestExpectations:
  • platform/mac/TestExpectations:
Location:
trunk/LayoutTests
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r258638 r258639  
     12020-03-18  Antoine Quint  <graouts@apple.com>
     2
     3        [macOS iOS ] animations/animation-direction-normal.html is flaky failing
     4        https://bugs.webkit.org/show_bug.cgi?id=206685
     5        <rdar://problem/58841791>
     6
     7        Reviewed by Antti Koivisto.
     8
     9        To make this test robust we animate a non-accelerated property and we use the Web Animations API to set the time
     10        at which we want to pause the animation (2.5s).
     11
     12        * animations/animation-direction-normal-expected.txt:
     13        * animations/animation-direction-normal.html:
     14        * platform/ios-wk2/TestExpectations:
     15        * platform/mac/TestExpectations:
     16
    1172020-03-18  Jason Lawrence  <lawrence.j@apple.com>
    218
  • trunk/LayoutTests/animations/animation-direction-normal-expected.txt

    r88641 r258639  
    1 PASS - "webkitTransform" property for "box" element at 0.5s saw something close to: 1,0,0,1,50,0
    2 PASS - "webkitTransform" property for "box" element at 1s saw something close to: 1,0,0,1,100,0
    3 PASS - "webkitTransform" property for "box" element at 2.5s saw something close to: 1,0,0,1,50,0
     1PASS - "margin-left" property for "box" element at 0.5s saw something close to: 50
     2PASS - "margin-left" property for "box" element at 1s saw something close to: 100
     3PASS - "margin-left" property for "box" element at 2.5s saw something close to: 50
    44
  • trunk/LayoutTests/animations/animation-direction-normal.html

    r88641 r258639  
    3131    }
    3232    @-webkit-keyframes "move1" {
    33       from { -webkit-transform: translateX(0px); }
    34       to   { -webkit-transform: translateX(200px); }
     33      from { margin-left: 0px; }
     34      to   { margin-left: 200px; }
    3535    }
    3636    #result {
     
    4242    const expectedValues = [
    4343      // [animation-name, time, element-id, property, expected-value, tolerance]
    44       ["move1", 0.5, "box", "webkitTransform", [1,0,0,1, 50,0], 20],
    45       ["move1", 1.0, "box", "webkitTransform", [1,0,0,1,100,0], 20],
    46       ["move1", 2.5, "box", "webkitTransform", [1,0,0,1, 50,0], 20],
     44      ["move1", 0.5, "box", "margin-left", 50, 20],
     45      ["move1", 1.0, "box", "margin-left", 100, 20],
     46      ["move1", 2.5, "box", "margin-left", 50, 20],
    4747    ];
    4848
    4949    function pauseAnimation()
    5050    {
    51         document.getElementById("box").style.webkitAnimationPlayState = "paused";
     51        const box = document.getElementById("box");
     52        box.style.webkitAnimationPlayState = "paused";
     53        box.getAnimations()[0].currentTime = 2500;
    5254    }
    5355
  • trunk/LayoutTests/platform/ios-wk2/TestExpectations

    r258627 r258639  
    13191319webkit.org/b/206630 [ Release ] fast/forms/validationMessage.html [ Pass Timeout ]
    13201320
    1321 webkit.org/b/206685 [ Debug ] animations/animation-direction-normal.html [ Pass Failure ]
    1322 
    13231321webkit.org/b/206687 imported/w3c/web-platform-tests/beacon/idlharness.any.html [ Pass Timeout ]
    13241322
  • trunk/LayoutTests/platform/mac/TestExpectations

    r258634 r258639  
    19121912webkit.org/b/203222 svg/wicd/rightsizing-grid.xhtml [ Pass Failure ]
    19131913
    1914 webkit.org/b/206685 animations/animation-direction-normal.html [ Pass Failure ]
    1915 
    19161914webkit.org/b/206711 http/wpt/resource-timing/rt-resource-errors.html [ Pass Failure ]
    19171915
Note: See TracChangeset for help on using the changeset viewer.