Changeset 258642 in webkit

Timestamp:

Mar 18, 2020 10:02:27 AM (4 years ago)

Author:

aakash_jain@apple.com

Message:

commit-queue should allow patches which are reviewed by patch author
​https://bugs.webkit.org/show_bug.cgi?id=209231

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-build/steps.py:

(BugzillaMixin._does_patch_have_acceptable_review_flag):

Location:

trunk/Tools

Files:

• BuildSlaveSupport/ews-build/steps.py (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/ews-build/steps.py

@@ -451 +451 @@
                     if self.addURLs:
                         self.addURL('Reviewed by: {}'.format(patch_reviewer), '')
-                    if patch_reviewer == patch_json.get('creator'):
-                        self._addToLog('stdio', 'Patch {} is r+ by the patch author {} itself. This seems like a mistake.\n'.format(patch_id, patch_reviewer))
-                        return 0
                     return 1
                 if review_status in ['-', '?']:

trunk/Tools/ChangeLog

@@ +1 @@
+2020-03-18  Aakash Jain  <aakash_jain@apple.com>
+
+        commit-queue should allow patches which are reviewed by patch author
+        https://bugs.webkit.org/show_bug.cgi?id=209231
+
+        Reviewed by Jonathan Bedard.
+
+        * BuildSlaveSupport/ews-build/steps.py:
+        (BugzillaMixin._does_patch_have_acceptable_review_flag):
+
 2020-03-18  Philippe Normand  <pnormand@igalia.com>