Changeset 258651 in webkit


Ignore:
Timestamp:
Mar 18, 2020 11:12:38 AM (4 years ago)
Author:
commit-queue@webkit.org
Message:

frame/iframe scrolling attribute does to recognize value "noscroll" or "off"
​https://bugs.webkit.org/show_bug.cgi?id=208570

Patch by Frederic Wang <​fwang@igalia.com> on 2020-03-18
Reviewed by Rob Buis.

Source/WebCore:

Tests: imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/the-page/iframe-scrolling-attribute.html

imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/the-page/iframe-scrolling-attribute-values.html

  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::scrollingMode const): Treat "noscroll" and "off" the same as "no".

LayoutTests:

Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r258650 r258651  
     12020-03-18  Frederic Wang  <fwang@igalia.com>
     2
     3        frame/iframe scrolling attribute does to recognize value "noscroll" or "off"
     4        https://bugs.webkit.org/show_bug.cgi?id=208570
     5
     6        Reviewed by Rob Buis.
     7
     8        * TestExpectations: Remove expectation failures.
     9
    1102020-03-18  Jason Lawrence  <lawrence.j@apple.com>
    211

  • trunk/LayoutTests/TestExpectations

    r258553 r258651  
    10651065imported/w3c/web-platform-tests/IndexedDB/abort-in-initial-upgradeneeded.html [ Pass Failure ]
    10661066imported/w3c/web-platform-tests/IndexedDB/clone-before-keypath-eval.html [ Pass Failure ]
    1067 
    1068 # noscroll and off are not supported
    1069 webkit.org/b/208570 imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/the-page/iframe-scrolling-attribute-values.html [ ImageOnlyFailure ]
    1070 webkit.org/b/208570 imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/the-page/iframe-scrolling-attribute.html [ ImageOnlyFailure ]
    10711067
    10721068# Those WPT tests are flaky when failing.

  • trunk/Source/WebCore/ChangeLog

    r258649 r258651  
     12020-03-18  Frederic Wang  <fwang@igalia.com>
     2
     3        frame/iframe scrolling attribute does to recognize value "noscroll" or "off"
     4        https://bugs.webkit.org/show_bug.cgi?id=208570
     5
     6        Reviewed by Rob Buis.
     7
     8        Tests: imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/the-page/iframe-scrolling-attribute.html
     9               imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/the-page/iframe-scrolling-attribute-values.html
     10
     11        * html/HTMLFrameElementBase.cpp:
     12        (WebCore::HTMLFrameElementBase::scrollingMode const): Treat "noscroll" and "off" the same as "no".
     13
    1142020-03-18  Chris Dumez  <cdumez@apple.com>
    215

  • trunk/Source/WebCore/html/HTMLFrameElementBase.cpp

    r254498 r258651  
    223223ScrollbarMode HTMLFrameElementBase::scrollingMode() const
    224224{
    225     return equalLettersIgnoringASCIICase(attributeWithoutSynchronization(scrollingAttr), "no")
     225    auto scrollingAttribute = attributeWithoutSynchronization(scrollingAttr);
     226    return equalLettersIgnoringASCIICase(scrollingAttribute, "no")
     227        || equalLettersIgnoringASCIICase(scrollingAttribute, "noscroll")
     228        || equalLettersIgnoringASCIICase(scrollingAttribute, "off")
    226229        ? ScrollbarAlwaysOff : ScrollbarAuto;
    227230}
Note: See TracChangeset for help on using the changeset viewer.