Changeset 258658 in webkit

Timestamp:

Mar 18, 2020 12:28:39 PM (4 years ago)

Author:

mmaxfield@apple.com

Message:

REGRESSION(r254389): Cordova throws an exception because it expects a hyphen inside navigator.locale
​https://bugs.webkit.org/show_bug.cgi?id=208969
<rdar://problem/59845517>

Reviewed by Darin Adler.

We want to thwart fingerprinting by minimizing the list of locales, but we also don't want to break existing apps.
We can achieve both by a linked-on-or-after check.

• wtf/cocoa/LanguageCocoa.mm:

(WTF::canMinimizeLanguages):

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/cocoa/LanguageCocoa.mm (modified) (2 diffs)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2020-03-18  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        REGRESSION(r254389): Cordova throws an exception because it expects a hyphen inside navigator.locale
+        https://bugs.webkit.org/show_bug.cgi?id=208969
+        <rdar://problem/59845517>
+
+        Reviewed by Darin Adler.
+
+        We want to thwart fingerprinting by minimizing the list of locales, but we also don't want to break existing apps.
+        We can achieve both by a linked-on-or-after check.
+
+        * wtf/cocoa/LanguageCocoa.mm:
+        (WTF::canMinimizeLanguages):
+
 2020-03-17  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WTF/wtf/cocoa/LanguageCocoa.mm

@@ -28 +28 @@
 
 #import <wtf/NeverDestroyed.h>
+#import <wtf/cocoa/RuntimeApplicationChecksCocoa.h>
 #import <wtf/spi/cocoa/NSLocaleSPI.h>
 
@@ -34 +35 @@
 bool canMinimizeLanguages()
 {
-    static bool result = [NSLocale respondsToSelector:@selector(minimizedLanguagesFromLanguages:)];
+    static const bool result = []() -> bool {
+#if PLATFORM(MAC)
+        if (applicationSDKVersion() < DYLD_MACOSX_VERSION_10_15_4)
+            return false;
+#endif
+#if PLATFORM(IOS)
+        if (applicationSDKVersion() < DYLD_IOS_VERSION_13_4)
+            return false;
+#endif
+        return [NSLocale respondsToSelector:@selector(minimizedLanguagesFromLanguages:)];
+    }();
     return result;
 }