Changeset 258717 in webkit
- Timestamp:
- Mar 19, 2020 11:28:58 AM (4 years ago)
- Location:
- trunk/Source/JavaScriptCore
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/JavaScriptCore/ChangeLog
r258698 r258717 1 2020-03-18 Yusuke Suzuki <ysuzuki@apple.com> 2 3 sanitizeStackForVMImpl writes below stack pointer, triggers huge warning spam from valgrind 4 https://bugs.webkit.org/show_bug.cgi?id=199295 5 6 Reviewed by Mark Lam. 7 8 During sanitizeStackForVMImpl, we should not access to the region beyond the stack-pointer. 9 This patch changes stack-pointer while sanitizeStackForVMImpl is zero-filling the old stack region. 10 11 * llint/LowLevelInterpreter.asm: 12 1 13 2020-03-19 Charlie Turner <cturner@igalia.com> 2 14 -
trunk/Source/JavaScriptCore/llint/LowLevelInterpreter.asm
r257466 r258717 1419 1419 loadp 4[sp], a0 1420 1420 end 1421 const vm = a01421 const vmOrStartSP = a0 1422 1422 const address = a1 1423 1423 const zeroValue = a2 1424 1424 1425 loadp VM::m_lastStackTop[vm], address 1425 loadp vmOrStartSP::m_lastStackTop[vmOrStartSP], address 1426 move sp, zeroValue 1427 storep zeroValue, vmOrStartSP::m_lastStackTop[vmOrStartSP] 1428 move sp, vmOrStartSP 1429 1426 1430 bpbeq sp, address, .zeroFillDone 1427 1431 move address, sp 1432 1428 1433 move 0, zeroValue 1429 1434 .zeroFillLoop: 1430 1435 storep zeroValue, [address] 1431 1436 addp PtrSize, address 1432 bpa sp, address, .zeroFillLoop1437 bpa vmOrStartSP, address, .zeroFillLoop 1433 1438 1434 1439 .zeroFillDone: 1435 move sp, address 1436 storep address, VM::m_lastStackTop[vm] 1440 move vmOrStartSP, sp 1437 1441 ret 1438 1442
Note: See TracChangeset
for help on using the changeset viewer.