Changeset 258729 in webkit

Timestamp:

Mar 19, 2020 2:35:47 PM (4 years ago)

Author:

Nikita Vasilyev

Message:

Web Inspector: remove redundant code in TreeOutline.prototype.removeChildAtIndex
​https://bugs.webkit.org/show_bug.cgi?id=209301

Reviewed by Joseph Pecoraro.

• UserInterface/Views/TreeOutline.js:

(WI.TreeOutline.prototype.removeChildAtIndex):
Check suppressSelectSibling once instead of three times.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/TreeOutline.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2020-03-19  Nikita Vasilyev  <nvasilyev@apple.com>
+
+        Web Inspector: remove redundant code in TreeOutline.prototype.removeChildAtIndex
+        https://bugs.webkit.org/show_bug.cgi?id=209301
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/Views/TreeOutline.js:
+        (WI.TreeOutline.prototype.removeChildAtIndex):
+        Check `suppressSelectSibling` once instead of three times.
+
 2020-03-17  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js

@@ -361 +361 @@
         let parent = child.parent;
 
-        if (child.deselect(suppressOnDeselect)) {
-            if (child.previousSibling && !suppressSelectSibling)
+        if (child.deselect(suppressOnDeselect) && !suppressSelectSibling) {
+            if (child.previousSibling)
                 child.previousSibling.select(true, false);
-            else if (child.nextSibling && !suppressSelectSibling)
+            else if (child.nextSibling)
                 child.nextSibling.select(true, false);
-            else if (!suppressSelectSibling)
+            else
                 parent.select(true, false);
         }