Changeset 258739 in webkit

Timestamp:

Mar 19, 2020 4:05:24 PM (4 years ago)

Author:

eric.carlson@apple.com

Message:

Allow for some tolerance when checking canvas pixels in fast/mediastream tests
​https://bugs.webkit.org/show_bug.cgi?id=209259
<rdar://problem/60609789>

Unreviewed tweak of r258700, increase the maximum tolerance to +/- 2.

• resources/platform-helper.js:

(videoCanvasPixelComparisonTolerance):
(checkPixelColorWithTolerance):

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• resources/platform-helper.js (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2020-03-19  Eric Carlson  <eric.carlson@apple.com>
+
+        Allow for some tolerance when checking canvas pixels in fast/mediastream tests
+        https://bugs.webkit.org/show_bug.cgi?id=209259
+        <rdar://problem/60609789>
+
+        Unreviewed tweak of r258700, increase the maximum tolerance to +/- 2.
+
+        * resources/platform-helper.js:
+        (videoCanvasPixelComparisonTolerance):
+        (checkPixelColorWithTolerance):
+
 2020-03-19  Brent Fulgham  <bfulgham@apple.com>
 

trunk/LayoutTests/resources/platform-helper.js

@@ -20 +20 @@
 {
     const tolerance = videoCanvasPixelComparisonTolerance();
-    return Math.abs(pixel[0] - r) < tolerance
-        && Math.abs(pixel[1] - g) < tolerance
-        && Math.abs(pixel[2] - b) < tolerance
-        && Math.abs(pixel[3] - a) < tolerance;
+    return Math.abs(pixel[0] - r) <= tolerance
+        && Math.abs(pixel[1] - g) <= tolerance
+        && Math.abs(pixel[2] - b) <= tolerance
+        && Math.abs(pixel[3] - a) <= tolerance;
 }