Changeset 258749 in webkit

Timestamp:

Mar 19, 2020 8:05:11 PM (4 years ago)

Author:

Peng Liu

Message:

Safari video gravity changes performance improvements
​https://bugs.webkit.org/show_bug.cgi?id=209316

Reviewed by Eric Carlson.

Remove an unnecessary (and harmful) call of setVideoLayerFrame in WebAVPlayerLayer:layoutSublayers.

When a video with the gravity AVLayerVideoGravityResizeAspectFill needs to enter the
picture-in-picture mode from fullscreen, the extra call of setVideoLayerFrame will send
an extra IPC message to the Web process to set the video layer bounds. So the [CATransaction commit]
will need to wait for three property changes to complete - two in the Web process, and one in the
UI process. The interval of the two property changes in the Web process is over 100 ms, because we
delay the call of resolveBounds (which calls the second setVideoLayerFrame) at least 100 ms
in WebAVPlayerLayer:layoutSublayers. That leads to long durations of core animation commits.
In the test, the longest duration of commits is over 500 ms. After applying this patch,
the longest duration in the test is about 50 ms.

• platform/ios/VideoFullscreenInterfaceAVKit.mm:

(-[WebAVPlayerLayer layoutSublayers]):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/ios/VideoFullscreenInterfaceAVKit.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-03-19  Peng Liu  <peng.liu6@apple.com>
+
+        Safari video gravity changes performance improvements
+        https://bugs.webkit.org/show_bug.cgi?id=209316
+
+        Reviewed by Eric Carlson.
+
+        Remove an unnecessary (and harmful) call of setVideoLayerFrame in WebAVPlayerLayer:layoutSublayers.
+
+        When a video with the gravity AVLayerVideoGravityResizeAspectFill needs to enter the
+        picture-in-picture mode from fullscreen, the extra call of setVideoLayerFrame will send
+        an extra IPC message to the Web process to set the video layer bounds. So the [CATransaction commit]
+        will need to wait for three property changes to complete - two in the Web process, and one in the
+        UI process. The interval of the two property changes in the Web process is over 100 ms, because we
+        delay the call of resolveBounds (which calls the second setVideoLayerFrame) at least 100 ms
+        in WebAVPlayerLayer:layoutSublayers. That leads to long durations of core animation commits.
+        In the test, the longest duration of commits is over 500 ms. After applying this patch,
+        the longest duration in the test is about 50 ms.
+
+        * platform/ios/VideoFullscreenInterfaceAVKit.mm:
+        (-[WebAVPlayerLayer layoutSublayers]):
+
 2020-03-19  Tim Horton  <timothy_horton@apple.com>
 

trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm

@@ -280 +280 @@
     } else if ([AVLayerVideoGravityResizeAspectFill isEqualToString:self.videoGravity]) {
         sourceVideoFrame = smallestRectWithAspectRatioAroundRect(videoAspectRatio, self.modelVideoLayerFrame);
-        self.modelVideoLayerFrame = CGRectMake(0, 0, sourceVideoFrame.width(), sourceVideoFrame.height());
-        if (auto* model = _fullscreenInterface->videoFullscreenModel())
-            model->setVideoLayerFrame(self.modelVideoLayerFrame);
         targetVideoFrame = smallestRectWithAspectRatioAroundRect(videoAspectRatio, self.bounds);
     } else