Changeset 258818 in webkit

Timestamp:

Mar 22, 2020 12:42:18 AM (4 years ago)

Author:

Devin Rousso

Message:

Web Inspector: Uncaught Exception: Right side of assignment cannot be destructured (at QuickConsole.js:358:30)
​https://bugs.webkit.org/show_bug.cgi?id=209388

Reviewed by Joseph Pecoraro.

• UserInterface/Views/QuickConsole.js:

(WI.QuickConsole.prototype._handleFramePageExecutionContextChanged):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/QuickConsole.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2020-03-22  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: Uncaught Exception: Right side of assignment cannot be destructured (at QuickConsole.js:358:30)
+        https://bugs.webkit.org/show_bug.cgi?id=209388
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/Views/QuickConsole.js:
+        (WI.QuickConsole.prototype._handleFramePageExecutionContextChanged):
+
 2020-03-21  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/QuickConsole.js

@@ -351 +351 @@
     _handleFramePageExecutionContextChanged(event)
     {
-        if (this._restoreSelectedExecutionContextForFrame !== event.target)
+        let frame = event.target;
+
+        if (this._restoreSelectedExecutionContextForFrame !== frame)
             return;
 
         this._restoreSelectedExecutionContextForFrame = null;
 
-        let {context} = event.data;
-
         this._useExecutionContextOfInspectedNode = false;
-        this._setActiveExecutionContext(context);
+        this._setActiveExecutionContext(frame.pageExecutionContext);
     }