Changeset 258858 in webkit

Timestamp:

Mar 23, 2020 10:50:08 AM (4 years ago)

Author:

graouts@webkit.org

Message:

DocumentTimeline / CSSTransition objects are leaking on CNN.com
​https://bugs.webkit.org/show_bug.cgi?id=208069
<rdar://problem/59680143>

Reviewed by Darin Adler.

Integrating post-commit review feedback from Darin.

Source/WebCore:

• testing/Internals.cpp:

(WebCore::Internals::animationWithIdExists const):

Source/WTF:

• wtf/ListHashSet.h:

(WTF::=):

Location:

trunk/Source

Files:

• WTF/ChangeLog (modified) (1 diff)
• WTF/wtf/ListHashSet.h (modified) (1 diff)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/testing/Internals.cpp (modified) (1 diff)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2020-03-23  Antoine Quint  <graouts@apple.com>
+
+        DocumentTimeline / CSSTransition objects are leaking on CNN.com
+        https://bugs.webkit.org/show_bug.cgi?id=208069
+        <rdar://problem/59680143>
+
+        Reviewed by Darin Adler.
+
+        Integrating post-commit review feedback from Darin. 
+
+        * wtf/ListHashSet.h:
+        (WTF::=):
+
 2020-03-23  Michael Catanzaro  <mcatanzaro@gnome.org>
 

trunk/Source/WTF/wtf/ListHashSet.h

@@ -352 +352 @@
 inline ListHashSet<T, U>& ListHashSet<T, U>::operator=(ListHashSet&& other)
 {
-    ListHashSet tmp(WTFMove(other));
-    swap(tmp);
+    ListHashSet movedSet(WTFMove(other));
+    swap(movedSet);
     return *this;
 }

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-03-23  Antoine Quint  <graouts@apple.com>
+
+        DocumentTimeline / CSSTransition objects are leaking on CNN.com
+        https://bugs.webkit.org/show_bug.cgi?id=208069
+        <rdar://problem/59680143>
+
+        Reviewed by Darin Adler.
+
+        Integrating post-commit review feedback from Darin. 
+
+        * testing/Internals.cpp:
+        (WebCore::Internals::animationWithIdExists const):
+
 2020-03-23  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/testing/Internals.cpp

@@ -1040 +1040 @@
 {
     for (auto* animation : WebAnimation::instances()) {
-        if (animation && animation->id() == id)
+        if (animation->id() == id)
             return true;
     }