Changeset 258900 in webkit

Timestamp:

Mar 23, 2020 7:44:31 PM (4 years ago)

Author:

Devin Rousso

Message:

Web Inspector: REGRESSION(r257791): event breakpoint icon should be [E]
​https://bugs.webkit.org/show_bug.cgi?id=209434

Reviewed by Timothy Hatcher.

• UserInterface/Images/TypeIcons.svg:

• UserInterface/Views/PathComponentIcons.css:

(.snapshot-list-icon .icon):
(@media (prefers-color-scheme: dark) .snapshot-list-icon .icon):
Drive-by: make a separate "HeapSnapshotList" target so that it won't be affected if "Events"

is ever changed.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Images/TypeIcons.svg (modified) (2 diffs)
• UserInterface/Views/PathComponentIcons.css (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2020-03-23  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: REGRESSION(r257791): event breakpoint icon should be [E]
+        https://bugs.webkit.org/show_bug.cgi?id=209434
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Images/TypeIcons.svg:
+
+        * UserInterface/Views/PathComponentIcons.css:
+        (.snapshot-list-icon .icon):
+        (@media (prefers-color-scheme: dark) .snapshot-list-icon .icon):
+        Drive-by: make a separate "HeapSnapshotList" target so that it won't be affected if "Events"
+                  is ever changed.
+
 2020-03-23  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Images/TypeIcons.svg

@@ -321 +321 @@
     <g id="EventBreakpointInterval-dark" class="dark blue"><use href="#box"/><use href="#I"/></g>
     <g id="EventBreakpointInterval-light" class="light blue"><use href="#box"/><use href="#I"/></g>
-    <g id="EventBreakpointListener-dark" class="dark blue"><use href="#box"/><use href="#I"/></g>
-    <g id="EventBreakpointListener-light" class="light blue"><use href="#box"/><use href="#I"/></g>
+    <g id="EventBreakpointListener-dark" class="dark blue"><use href="#box"/><use href="#E"/></g>
+    <g id="EventBreakpointListener-light" class="light blue"><use href="#box"/><use href="#E"/></g>
     <g id="EventBreakpointTimeout-dark" class="dark blue"><use href="#box"/><use href="#T"/></g>
     <g id="EventBreakpointTimeout-light" class="light blue"><use href="#box"/><use href="#T"/></g>
@@ -338 +338 @@
     <g id="HeapSnapshotInstances-dark" class="dark yellow"><use href="#box"/><use href="#O"/></g>
     <g id="HeapSnapshotInstances-light" class="light yellow"><use href="#box"/><use href="#O"/></g>
+    <g id="HeapSnapshotList-dark" class="dark grey"><use href="#box"/><use href="#list"/></g>
+    <g id="HeapSnapshotList-light" class="light grey"><use href="#box"/><use href="#list"/></g>
     <g id="HeapSnapshotObjectGraph-dark" class="dark red"><use href="#box"/><use href="#braces"/></g>
     <g id="HeapSnapshotObjectGraph-light" class="light red"><use href="#box"/><use href="#braces"/></g>

trunk/Source/WebInspectorUI/UserInterface/Views/PathComponentIcons.css

@@ -101 +101 @@
 
 .snapshot-list-icon .icon {
-    content: url(../Images/TypeIcons.svg#Events-light);
+    content: url(../Images/TypeIcons.svg#HeapSnapshotList-light);
 }
 
@@ -194 +194 @@
 
     .snapshot-list-icon .icon {
-        content: url(../Images/TypeIcons.svg#Events-dark);
+        content: url(../Images/TypeIcons.svg#HeapSnapshotList-dark);
     }