Changeset 258964 in webkit


Ignore:
Timestamp:
Mar 24, 2020 5:27:56 PM (4 years ago)
Author:
sbarati@apple.com
Message:

Memory::fastMappedBytes() is wrong
https://bugs.webkit.org/show_bug.cgi?id=209488

Reviewed by Mark Lam.

  • wasm/WasmMemory.cpp:

(JSC::Wasm::Memory::fastMappedBytes):

Location:
trunk/Source/JavaScriptCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/JavaScriptCore/ChangeLog

    r258952 r258964  
     12020-03-24  Saam Barati  <sbarati@apple.com>
     2
     3        Memory::fastMappedBytes() is wrong
     4        https://bugs.webkit.org/show_bug.cgi?id=209488
     5
     6        Reviewed by Mark Lam.
     7
     8        * wasm/WasmMemory.cpp:
     9        (JSC::Wasm::Memory::fastMappedBytes):
     10
    1112020-03-24  Keith Miller  <keith_miller@apple.com>
    212
  • trunk/Source/JavaScriptCore/wasm/WasmMemory.cpp

    r254714 r258964  
    359359{
    360360    static_assert(sizeof(uint64_t) == sizeof(size_t), "We rely on allowing the maximum size of Memory we map to be 2^32 + redzone which is larger than fits in a 32-bit integer that we'd pass to mprotect if this didn't hold.");
    361     return static_cast<size_t>(std::numeric_limits<uint32_t>::max()) + fastMappedRedzoneBytes();
     361    return (static_cast<size_t>(1) << 32) + fastMappedRedzoneBytes();
    362362}
    363363
Note: See TracChangeset for help on using the changeset viewer.