Changeset 258975 in webkit


Ignore:
Timestamp:
Mar 25, 2020 3:19:09 AM (4 years ago)
Author:
cturner@igalia.com
Message:

[GStreamer] Remove noisy warning about broken LC support
https://bugs.webkit.org/show_bug.cgi?id=209472

Reviewed by Philippe Normand.

  • platform/graphics/gstreamer/GStreamerCommon.cpp:

(WebCore::initializeGStreamer): There's no seemingly nice way of
ensuring this message is issued once in WebKit the
lifetime. Issuing multiple times is upsetting users. We can't rely
on Gst logging at this point, and there's no established story of
using the LOG_CHANNEL stuff on WPE/GTK ports for suppressible
WebKit message AFAICT.

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r258971 r258975  
     12020-03-25  Charlie Turner  <cturner@igalia.com>
     2
     3        [GStreamer] Remove noisy warning about broken LC support
     4        https://bugs.webkit.org/show_bug.cgi?id=209472
     5
     6        Reviewed by Philippe Normand.
     7
     8        * platform/graphics/gstreamer/GStreamerCommon.cpp:
     9        (WebCore::initializeGStreamer): There's no seemingly nice way of
     10        ensuring this message is issued once in WebKit the
     11        lifetime. Issuing multiple times is upsetting users. We can't rely
     12        on Gst logging at this point, and there's no established story of
     13        using the LOG_CHANNEL stuff on WPE/GTK ports for suppressible
     14        WebKit message AFAICT.
     15
    1162020-03-24  Andres Gonzalez  <andresg_22@apple.com>
    217
  • trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp

    r258832 r258975  
    269269                    gst_plugin_feature_set_rank(GST_PLUGIN_FEATURE_CAST(avAACDecoderFactory.get()), GST_RANK_MARGINAL);
    270270            }
    271         } else
    272             WTFLogAlways("WARNING: You might have broken LC support in your AAC decoders, consider installing fdkaacdec");
     271        }
    273272
    274273#endif
Note: See TracChangeset for help on using the changeset viewer.