Changeset 258997 in webkit

Timestamp:

Mar 25, 2020 11:08:01 AM (4 years ago)

Author:

aakash_jain@apple.com

Message:

[ews] status-bubble should link to buildbot queue while waiting in queue
​https://bugs.webkit.org/show_bug.cgi?id=209543

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-app/ews/views/statusbubble.py:

(StatusBubble._build_bubble): Link to buildbot queue whil patch is waiting in queue.

• BuildSlaveSupport/ews-app/ews/common/buildbot.py:

(Buildbot.update_icons_for_queues_mapping): Generate the mapping for shortname to full queue name.

Location:

trunk/Tools

Files:

• BuildSlaveSupport/ews-app/ews/common/buildbot.py (modified) (2 diffs)
• BuildSlaveSupport/ews-app/ews/views/statusbubble.py (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/ews-app/ews/common/buildbot.py

@@ -40 +40 @@
     SUCCESS, WARNINGS, FAILURE, SKIPPED, EXCEPTION, RETRY, CANCELLED = ALL_RESULTS
     icons_for_queues_mapping = {}
+    queue_name_by_shortname_mapping = {}
     builder_name_to_id_mapping = {}
 
@@ -97 +98 @@
     def update_icons_for_queues_mapping(cls):
         config = cls.fetch_config()
+        if not config:
+            _log.warn('Unable to fetch buildbot config.json')
         for builder in config.get('builders', []):
             shortname = builder.get('shortname')
             Buildbot.icons_for_queues_mapping[shortname] = builder.get('icon')
+            Buildbot.queue_name_by_shortname_mapping[shortname] = builder.get('name')
 
     @classmethod

trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py

@@ -97 +97 @@
             if not queue_position:
                 return None
+            if self._get_parent_queue(queue):
+                queue = self._get_parent_queue(queue)
+            queue_full_name = Buildbot.queue_name_by_shortname_mapping.get(queue)
+            if queue_full_name:
+                bubble['url'] = 'https://{}/#/builders/{}'.format(config.BUILDBOT_SERVER_HOST, queue_full_name)
             bubble['details_message'] = 'Waiting in queue, processing has not started yet.\n\nPosition in queue: {}'.format(queue_position)
             return bubble

trunk/Tools/ChangeLog

@@ +1 @@
+2020-03-25  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews] status-bubble should link to buildbot queue while waiting in queue
+        https://bugs.webkit.org/show_bug.cgi?id=209543
+
+        Reviewed by Jonathan Bedard.
+
+        * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
+        (StatusBubble._build_bubble): Link to buildbot queue whil patch is waiting in queue.
+        * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
+        (Buildbot.update_icons_for_queues_mapping): Generate the mapping for shortname to full queue name.
+
 2020-03-25  Ting-Wei Lan  <lantw44@gmail.com>