Changeset 259017 in webkit

Timestamp:

Mar 25, 2020 4:05:41 PM (4 years ago)

Author:

zhifei_fang@apple.com

Message:

[Timeline] Fix the out of bound dot index
​https://bugs.webkit.org/show_bug.cgi?id=209492

Reviewed by Jonathan Bedard.

• resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:

(Timeline.CanvasSeriesComponent):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2020-03-25  Zhifei Fang  <zhifei_fang@apple.com>
+
+        [Timeline] Fix the out of bound dot index
+        https://bugs.webkit.org/show_bug.cgi?id=209492
+
+        Reviewed by Jonathan Bedard.
+
+        * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
+        (Timeline.CanvasSeriesComponent):
+
 2020-03-25  Daniel Bates  <dabates@apple.com>
 

trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js

@@ -386 +386 @@
         if (endScalesIndex >= scales.length)
             endScalesIndex = scales.length - 1;
-        let currentDotIndex = startScalesIndex - (scales.length - dots.length);
-        if (currentDotIndex < 0)
-            currentDotIndex = 0;
-        for (let i = currentDotIndex; i <= startScalesIndex; i++) {
+        let currentDotIndex = 0;
+        for (let i = currentDotIndex; i <= startScalesIndex && currentDotIndex < dots.length; i++) {
             const compResult = comp(scales[startScalesIndex], getScale(dots[currentDotIndex]));
             if (!reversed) {