Changeset 259056 in webkit

Timestamp:

Mar 26, 2020 11:00:18 AM (4 years ago)

Author:

dino@apple.com

Message:

Force Touch preview on ​file:/// URL works while clicking on the URL is blocked
​https://bugs.webkit.org/show_bug.cgi?id=209589
<rdar://57687893>

Reviewed by Antoine Quint.

The immediate action for links should never trigger on file: URLs.

• UIProcess/mac/WKImmediateActionController.mm:

(-[WKImmediateActionController _defaultAnimationController]):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/mac/WKImmediateActionController.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-03-26  Dean Jackson  <dino@apple.com>
+
+        Force Touch preview on file:/// URL works while clicking on the URL is blocked
+        https://bugs.webkit.org/show_bug.cgi?id=209589
+        <rdar://57687893>
+
+        Reviewed by Antoine Quint.
+
+        The immediate action for links should never trigger on file: URLs.
+
+        * UIProcess/mac/WKImmediateActionController.mm:
+        (-[WKImmediateActionController _defaultAnimationController]):
+
 2020-03-26  Per Arne Vollan  <pvollan@apple.com>
 

trunk/Source/WebKit/UIProcess/mac/WKImmediateActionController.mm

@@ -277 +277 @@
     String absoluteLinkURL = hitTestResult->absoluteLinkURL();
     if (!absoluteLinkURL.isEmpty()) {
+        if (WTF::protocolIs(absoluteLinkURL, "file")) {
+            _type = kWKImmediateActionNone;
+            return nil;
+        }
+
         if (WTF::protocolIs(absoluteLinkURL, "mailto")) {
             _type = kWKImmediateActionMailtoLink;