Changeset 259527 in webkit

Timestamp:

Apr 3, 2020 10:06:20 PM (4 years ago)

Author:

ddkilzer@apple.com

Message:

Build fix: HTMLFormElement should use WeakPtr to keep track of its FormNamedItem
​https://bugs.webkit.org/show_bug.cgi?id=209925

• html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::elementFromPastNamesMap const):

• Apply macros consistently. Regressed in r259513.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLFormElement.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-04-03  David Kilzer  <ddkilzer@apple.com>
+
+        Build fix: HTMLFormElement should use WeakPtr to keep track of its FormNamedItem
+        https://bugs.webkit.org/show_bug.cgi?id=209925
+
+        * html/HTMLFormElement.cpp:
+        (WebCore::HTMLFormElement::elementFromPastNamesMap const):
+        - Apply macros consistently.  Regressed in r259513.
+
 2020-04-03  Jack Lee  <shihchieh_lee@apple.com>
 

trunk/Source/WebCore/html/HTMLFormElement.cpp

@@ -765 +765 @@
 }
 
-#if ASSERT_ENABLED
+#if ASSERT_ENABLED || ENABLE(SECURITY_ASSERTIONS)
 void HTMLFormElement::assertItemCanBeInPastNamesMap(FormNamedItem* item) const
 {
@@ -790 +790 @@
         return nullptr;
     auto element = makeRefPtr(weakElement.get());
-#if ASSERT_ENABLED
+#if ASSERT_ENABLED || ENABLE(SECURITY_ASSERTIONS)
     assertItemCanBeInPastNamesMap(element->asFormNamedItem());
 #endif