Changeset 259545 in webkit


Ignore:
Timestamp:
Apr 4, 2020 11:17:21 PM (4 years ago)
Author:
keith_miller@apple.com
Message:

copy jsc CLI into JavaScriptCore.framework earlier
https://bugs.webkit.org/show_bug.cgi?id=210018

Reviewed by Mark Lam.

Some of our test scripts only copy the JavaScriptCore.framework
into the test directory and try to run jsc from there. We should
copy the jsc CLI ASAP so we don't need to build all the other test
binaries unless we actually need them.

Location:
trunk/Source/JavaScriptCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/JavaScriptCore/ChangeLog

    r259536 r259545  
     12020-04-04  Keith Miller  <keith_miller@apple.com>
     2
     3        copy jsc CLI into JavaScriptCore.framework earlier
     4        https://bugs.webkit.org/show_bug.cgi?id=210018
     5
     6        Reviewed by Mark Lam.
     7
     8        Some of our test scripts only copy the JavaScriptCore.framework
     9        into the test directory and try to run jsc from there. We should
     10        copy the jsc CLI ASAP so we don't need to build all the other test
     11        binaries unless we actually need them.
     12
     13        * JavaScriptCore.xcodeproj/project.pbxproj:
     14
    1152020-04-04  Alexey Shvayka  <shvaikalesh@gmail.com>
    216
  • trunk/Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj

    r258478 r259545  
    102102                        buildConfigurationList = 149C276C08902AFE008A9EFC /* Build configuration list for PBXAggregateTarget "All" */;
    103103                        buildPhases = (
    104                                 5DF7E1CC188E6B87003F9A46 /* Copy jsc into JavaScriptCore.framework */,
    105104                                539966E3237CD6740033B0D2 /* Create Versions/Current/Helpers symlink */,
    106105                        );
     
    1064010639                                932F5BDE0822A1C700736975 /* Frameworks */,
    1064110640                                5D5D8ABF0E0D0B0300F9C692 /* Create /usr/local/bin/jsc symlink */,
     10641                                53B3E04E2439A089001C4281 /* Copy jsc into JavaScriptCore.framework */,
    1064210642                        );
    1064310643                        buildRules = (
     
    1089110891                        shellScript = "# If on a deep-bundle system, set up a link from Helpers to Versions/A/Helpers\n\nif [[ \"${JAVASCRIPTCORE_HELPERS_DIR}\" =~ \"Versions\" ]]; then\n    if [[ \"${DEPLOYMENT_LOCATION}\" == \"NO\" ]]; then\n        ln -fhs Versions/Current/Helpers \"${BUILT_PRODUCTS_DIR}/${JAVASCRIPTCORE_HELPERS_DIR}/../../..\"\n    else\n        ln -fhs Versions/Current/Helpers \"${INSTALL_DIR}/../../..\"\n    fi\nfi\nexit 0\n";
    1089210892                };
     10893                53B3E04E2439A089001C4281 /* Copy jsc into JavaScriptCore.framework */ = {
     10894                        isa = PBXShellScriptBuildPhase;
     10895                        buildActionMask = 2147483647;
     10896                        files = (
     10897                        );
     10898                        inputFileListPaths = (
     10899                        );
     10900                        inputPaths = (
     10901                                "$(BUILT_PRODUCTS_DIR)/jsc",
     10902                        );
     10903                        name = "Copy jsc into JavaScriptCore.framework";
     10904                        outputFileListPaths = (
     10905                        );
     10906                        outputPaths = (
     10907                                "$(BUILT_PRODUCTS_DIR)/$(JAVASCRIPTCORE_HELPERS_DIR)/jsc",
     10908                        );
     10909                        runOnlyForDeploymentPostprocessing = 0;
     10910                        shellPath = /bin/sh;
     10911                        shellScript = "set -e\n\n# Skip for Production builds.\nif [[ ${CONFIGURATION:=Debug} == \"Production\" ]]; then\n    exit\nfi\n\n# Copy and update the jsc binary to refer to JavaScriptCore.framework relative to its location.\nmkdir -p \"${BUILT_PRODUCTS_DIR}/${JAVASCRIPTCORE_HELPERS_DIR}\"\nditto \"${BUILT_PRODUCTS_DIR}/jsc\" \"${BUILT_PRODUCTS_DIR}/${JAVASCRIPTCORE_HELPERS_DIR}/jsc\"\ninstall_name_tool -change \"${JAVASCRIPTCORE_FRAMEWORKS_DIR}/JavaScriptCore.framework/Versions/A/JavaScriptCore\" \"@loader_path/../JavaScriptCore\" \"${BUILT_PRODUCTS_DIR}/${JAVASCRIPTCORE_HELPERS_DIR}/jsc\"\n\n";
     10912                };
    1089310913                53B4BD091F68AF8900D2BEA3 /* Generate Unified Sources */ = {
    1089410914                        isa = PBXShellScriptBuildPhase;
     
    1097510995                        shellPath = /bin/sh;
    1097610996                        shellScript = "if [[ \"${SKIP_INSTALL}\" == \"NO\" ]]; then\n    cp \"${SRCROOT}/API/tests/testapiScripts/testapi.js\" \"${DSTROOT}${INSTALL_PATH}/testapi.js\"\nfi\n";
    10977                 };
    10978                 5DF7E1CC188E6B87003F9A46 /* Copy jsc into JavaScriptCore.framework */ = {
    10979                         isa = PBXShellScriptBuildPhase;
    10980                         buildActionMask = 2147483647;
    10981                         files = (
    10982                         );
    10983                         inputPaths = (
    10984                                 "$(BUILT_PRODUCTS_DIR)/jsc",
    10985                         );
    10986                         name = "Copy jsc into JavaScriptCore.framework";
    10987                         outputPaths = (
    10988                                 "$(BUILT_PRODUCTS_DIR)/$(JAVASCRIPTCORE_HELPERS_DIR)/jsc",
    10989                         );
    10990                         runOnlyForDeploymentPostprocessing = 0;
    10991                         shellPath = /bin/sh;
    10992                         shellScript = "set -e\n\n# Skip for Production builds.\nif [[ ${CONFIGURATION:=Debug} == \"Production\" ]]; then\n    exit\nfi\n\n# Copy and update the jsc binary to refer to JavaScriptCore.framework relative to its location.\nmkdir -p \"${BUILT_PRODUCTS_DIR}/${JAVASCRIPTCORE_HELPERS_DIR}\"\nditto \"${BUILT_PRODUCTS_DIR}/jsc\" \"${BUILT_PRODUCTS_DIR}/${JAVASCRIPTCORE_HELPERS_DIR}/jsc\"\ninstall_name_tool -change \"${JAVASCRIPTCORE_FRAMEWORKS_DIR}/JavaScriptCore.framework/Versions/A/JavaScriptCore\" \"@loader_path/../JavaScriptCore\" \"${BUILT_PRODUCTS_DIR}/${JAVASCRIPTCORE_HELPERS_DIR}/jsc\"\n";
    1099310997                };
    1099410998                65788AA018B409EB00C189FF /* Offline Assemble */ = {
Note: See TracChangeset for help on using the changeset viewer.