Changeset 259660 in webkit


Ignore:
Timestamp:
Apr 7, 2020 12:59:24 PM (4 years ago)
Author:
aakash_jain@apple.com
Message:

[ews] Add unit-test for CheckPatchRelevance build step
https://bugs.webkit.org/show_bug.cgi?id=210140

Reviewed by Jonathan Bedard.

  • BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.

(TestCheckPatchRelevance):
(TestCheckPatchRelevance.test_relevant_patch):
(TestCheckPatchRelevance.test_non_relevant_patch):

Location:
trunk/Tools
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py

    r259464 r259660  
    21492149        self.expectHidden(True)
    21502150        self.expectOutcome(result=SKIPPED, state_string='Unapplied patch (skipped)')
     2151        return self.runStep()
     2152
     2153
     2154class TestCheckPatchRelevance(BuildStepMixinAdditions, unittest.TestCase):
     2155    def setUp(self):
     2156        self.longMessage = True
     2157        return self.setUpBuildStep()
     2158
     2159    def tearDown(self):
     2160        return self.tearDownBuildStep()
     2161
     2162    def test_relevant_patch(self):
     2163        CheckPatchRelevance._get_patch = lambda x: 'Sample patch; file: JSTests/'
     2164        self.setupStep(CheckPatchRelevance())
     2165        self.setProperty('buildername', 'JSC-Tests-EWS')
     2166        self.assertEqual(CheckPatchRelevance.haltOnFailure, True)
     2167        self.assertEqual(CheckPatchRelevance.flunkOnFailure, True)
     2168        self.expectOutcome(result=SUCCESS, state_string='Checked patch relevance')
     2169        return self.runStep()
     2170
     2171    def test_queue_without_relevance_info(self):
     2172        CheckPatchRelevance._get_patch = lambda x: 'Sample patch'
     2173        self.setupStep(CheckPatchRelevance())
     2174        self.setProperty('buildername', 'Commit-Queue')
     2175        CheckPatchStatusOnEWSQueues.get_patch_status = lambda cls, patch_id, queue: FAILURE
     2176        self.expectOutcome(result=SUCCESS, state_string='Checked patch relevance')
     2177        return self.runStep()
     2178
     2179    def test_non_relevant_patch(self):
     2180        CheckPatchRelevance._get_patch = lambda x: 'Sample patch'
     2181        self.setupStep(CheckPatchRelevance())
     2182        self.setProperty('buildername', 'JSC-Tests-EWS')
     2183        self.setProperty('patch_id', '1234')
     2184        CheckPatchStatusOnEWSQueues.get_patch_status = lambda cls, patch_id, queue: FAILURE
     2185        self.expectOutcome(result=FAILURE, state_string='Checked patch relevance (failure)')
    21512186        return self.runStep()
    21522187
  • trunk/Tools/ChangeLog

    r259655 r259660  
     12020-04-07  Aakash Jain  <aakash_jain@apple.com>
     2
     3        [ews] Add unit-test for CheckPatchRelevance build step
     4        https://bugs.webkit.org/show_bug.cgi?id=210140
     5
     6        Reviewed by Jonathan Bedard.
     7
     8        * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
     9        (TestCheckPatchRelevance):
     10        (TestCheckPatchRelevance.test_relevant_patch):
     11        (TestCheckPatchRelevance.test_non_relevant_patch):
     12
    1132020-04-07  Kate Cheney  <katherine_cheney@apple.com>
    214
Note: See TracChangeset for help on using the changeset viewer.