Changeset 259665 in webkit

Timestamp:

Apr 7, 2020 1:07:46 PM (4 years ago)

Author:

BJ Burg

Message:

Web Automation: Automation.inspectBrowsingContext should bring Web Inspector to front automatically
​https://bugs.webkit.org/show_bug.cgi?id=210137

Reviewed by Joseph Pecoraro.

• UIProcess/Automation/mac/WebAutomationSessionMac.mm:

(WebKit::WebAutomationSession::inspectBrowsingContext):
Previously, calling connect() would preload Web Inspector but not show its window. This
made it awkward to use the 'safari:automaticInspection' capability without subsequently
evaluating a debugger; statement to bring Web Inspector to front.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/Automation/mac/WebAutomationSessionMac.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-04-07  Brian Burg  <bburg@apple.com>
+
+        Web Automation: Automation.inspectBrowsingContext should bring Web Inspector to front automatically
+        https://bugs.webkit.org/show_bug.cgi?id=210137
+
+        Reviewed by Joseph Pecoraro.
+
+        * UIProcess/Automation/mac/WebAutomationSessionMac.mm:
+        (WebKit::WebAutomationSession::inspectBrowsingContext):
+        Previously, calling connect() would preload Web Inspector but not show its window. This
+        made it awkward to use the 'safari:automaticInspection' capability without subsequently
+        evaluating a `debugger;` statement to bring Web Inspector to front.
+
 2020-04-07  Kate Cheney  <katherine_cheney@apple.com>
 

trunk/Source/WebKit/UIProcess/Automation/mac/WebAutomationSessionMac.mm

@@ -58 +58 @@
     // We just want it loaded so it can pause if a breakpoint is hit during a command.
     if (page->inspector()) {
-        page->inspector()->connect();
+        page->inspector()->show();
 
         // Start collecting profile information immediately so the entire session is captured.