Changeset 259667 in webkit

Timestamp:

Apr 7, 2020 1:23:50 PM (4 years ago)

Author:

Truitt Savell

Message:

Unreviewed, reverting r259446.

Broke Windows testing

Reverted changeset:

"[Windows] Ignore render tree dump based results on Windows"
​https://bugs.webkit.org/show_bug.cgi?id=209897
​https://trac.webkit.org/changeset/259446

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/layout_tests/controllers/single_test_runner.py (modified) (1 diff)
• Scripts/webkitpy/layout_tests/run_webkit_tests.py (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2020-04-07  Truitt Savell  <tsavell@apple.com>
+
+        Unreviewed, reverting r259446.
+
+        Broke Windows testing
+
+        Reverted changeset:
+
+        "[Windows] Ignore render tree dump based results on Windows"
+        https://bugs.webkit.org/show_bug.cgi?id=209897
+        https://trac.webkit.org/changeset/259446
+
 2020-04-07  Aakash Jain  <aakash_jain@apple.com>
 

trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py

@@ -236 +236 @@
     def _compare_text(self, expected_text, actual_text):
         failures = []
-        if self._options.ignore_render_tree_dump_results and self._render_tree_dump_pattern.match(actual_text):
-            return failures
         if (expected_text and actual_text and
             # Assuming expected_text is already normalized.

trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

@@ -150 +150 @@
         optparse.make_option("--no-ref-tests", action="store_true",
             dest="no_ref_tests", help="Skip all ref tests"),
-        optparse.make_option("--ignore-render-tree-dump-results", action="store_true",
-            dest="ignore_render_tree_dump_results",
-            help="Don't compare or save results for render tree dump tests (they still run and crashes are reported)"),
         optparse.make_option("--tolerance",
             help="Ignore image differences less than this percentage (some "
@@ -473 +470 @@
         options.webkit_test_runner = True
 
-    # Don't maintain render tree dump results for Apple Windows port.
-    if port.port_name == "win":
-        options.ignore_render_tree_dump_results = True
-
     if options.leaks:
         options.additional_env_var.append("JSC_usePoisoning=0")