Changeset 259694 in webkit

Timestamp:

Apr 7, 2020 5:38:33 PM (4 years ago)

Author:

aakash_jain@apple.com

Message:

[ews] Improve summary for CheckPatchRelevance build step
​https://bugs.webkit.org/show_bug.cgi?id=210146

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-build/steps.py:

(CheckPatchRelevance): Improved success message.
(CheckPatchRelevance.start):
(CheckPatchRelevance.getResultSummary): Improved failure message.

• BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
• BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Updated accordingly.

Location:

trunk/Tools

Files:

• BuildSlaveSupport/ews-app/ews/views/statusbubble.py (modified) (1 diff)
• BuildSlaveSupport/ews-build/steps.py (modified) (2 diffs)
• BuildSlaveSupport/ews-build/steps_unittest.py (modified) (3 diffs)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py

@@ -63 +63 @@
                      '^Cleaned and updated working directory$', '^Checked out required revision$', '^Updated working directory$',
                      '^Validated patch$', '^Killed old processes$', '^Configured build$', '^OS:.*Xcode:', '(skipped)',
-                     '^Printed configuration$', '^Checked patch relevance$', '^Deleted .git/index.lock$',
+                     '^Printed configuration$', '^Patch contains relevant changes$', '^Deleted .git/index.lock$',
                      '^triggered.*$', '^Found modified ChangeLogs$', '^Created local git commit$', '^Set build summary$',
                      '^Validated commiter$', '^Validated commiter and reviewer$', '^Validated ChangeLog and Reviewer$',

trunk/Tools/BuildSlaveSupport/ews-build/steps.py

@@ -244 +244 @@
     name = 'check-patch-relevance'
     description = ['check-patch-relevance running']
-    descriptionDone = ['Checked patch relevance']
+    descriptionDone = ['Patch contains relevant changes']
     flunkOnFailure = True
     haltOnFailure = True
@@ -333 +333 @@
             return None
 
-        self._addToLog('stdio', 'This patch does not have relevant changes.')
+        self._addToLog('stdio', 'This patch does not contain relevant changes.')
         self.finished(FAILURE)
         self.build.results = SKIPPED
-        self.build.buildFinished(['Patch {} doesn\'t have relevant changes'.format(self.getProperty('patch_id', ''))], SKIPPED)
+        self.build.buildFinished(['Patch {} doesn\'t contain relevant changes'.format(self.getProperty('patch_id', ''))], SKIPPED)
         return None
 
+    def getResultSummary(self):
+        if self.results == FAILURE:
+            return {u'step': u'Patch doesn\'t contain relevant changes'}
+        return super(CheckPatchRelevance, self).getResultSummary()
 
 class BugzillaMixin(object):

trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py

@@ -2166 +2166 @@
         self.assertEqual(CheckPatchRelevance.haltOnFailure, True)
         self.assertEqual(CheckPatchRelevance.flunkOnFailure, True)
-        self.expectOutcome(result=SUCCESS, state_string='Checked patch relevance')
+        self.expectOutcome(result=SUCCESS, state_string='Patch contains relevant changes')
         return self.runStep()
 
@@ -2174 +2174 @@
         self.setProperty('buildername', 'Commit-Queue')
         CheckPatchStatusOnEWSQueues.get_patch_status = lambda cls, patch_id, queue: FAILURE
-        self.expectOutcome(result=SUCCESS, state_string='Checked patch relevance')
+        self.expectOutcome(result=SUCCESS, state_string='Patch contains relevant changes')
         return self.runStep()
 
@@ -2183 +2183 @@
         self.setProperty('patch_id', '1234')
         CheckPatchStatusOnEWSQueues.get_patch_status = lambda cls, patch_id, queue: FAILURE
-        self.expectOutcome(result=FAILURE, state_string='Checked patch relevance (failure)')
+        self.expectOutcome(result=FAILURE, state_string='Patch doesn\'t contain relevant changes')
         return self.runStep()
 

trunk/Tools/ChangeLog

@@ +1 @@
+2020-04-07  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews] Improve summary for CheckPatchRelevance build step
+        https://bugs.webkit.org/show_bug.cgi?id=210146
+
+        Reviewed by Jonathan Bedard.
+
+        * BuildSlaveSupport/ews-build/steps.py:
+        (CheckPatchRelevance): Improved success message.
+        (CheckPatchRelevance.start):
+        (CheckPatchRelevance.getResultSummary): Improved failure message.
+        * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
+        * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Updated accordingly.
+
 2020-04-07  Jiewen Tan  <jiewen_tan@apple.com>