Changeset 259719 in webkit

Timestamp:

Apr 8, 2020 9:17:55 AM (4 years ago)

Author:

aakash_jain@apple.com

Message:

[ews] Improve summary for CheckPatchRelevance build step (follow-up fix)
​https://bugs.webkit.org/show_bug.cgi?id=210146

Unreviewed follow-up fix.

Revert the failure message for CheckPatchRelevance to old one since it needs to match with status-bubble code.

• BuildSlaveSupport/ews-build/steps.py:
• BuildSlaveSupport/ews-build/steps_unittest.py:

(TestCheckPatchRelevance.test_non_relevant_patch):

Location:

trunk/Tools

Files:

• BuildSlaveSupport/ews-build/steps.py (modified) (1 diff)
• BuildSlaveSupport/ews-build/steps_unittest.py (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/ews-build/steps.py

@@ -347 +347 @@
             return None
 
-        self._addToLog('stdio', 'This patch does not contain relevant changes.')
+        self._addToLog('stdio', 'This patch does not have relevant changes.')
         self.finished(FAILURE)
         self.build.results = SKIPPED
-        self.build.buildFinished(['Patch {} doesn\'t contain relevant changes'.format(self.getProperty('patch_id', ''))], SKIPPED)
+        self.build.buildFinished(['Patch {} doesn\'t have relevant changes'.format(self.getProperty('patch_id', ''))], SKIPPED)
         return None
 
     def getResultSummary(self):
         if self.results == FAILURE:
-            return {u'step': u'Patch doesn\'t contain relevant changes'}
+            return {u'step': u'Patch doesn\'t have relevant changes'}
         return super(CheckPatchRelevance, self).getResultSummary()
 

trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py

@@ -2193 +2193 @@
         self.setProperty('buildername', 'JSC-Tests-EWS')
         self.setProperty('patch_id', '1234')
-        self.expectOutcome(result=FAILURE, state_string='Patch doesn\'t contain relevant changes')
+        self.expectOutcome(result=FAILURE, state_string='Patch doesn\'t have relevant changes')
         return self.runStep()
 

trunk/Tools/ChangeLog

@@ +1 @@
+2020-04-08  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews] Improve summary for CheckPatchRelevance build step (follow-up fix)
+        https://bugs.webkit.org/show_bug.cgi?id=210146
+
+        Unreviewed follow-up fix.
+
+        Revert the failure message for CheckPatchRelevance to old one since it needs to match with status-bubble code.
+        * BuildSlaveSupport/ews-build/steps.py:
+        * BuildSlaveSupport/ews-build/steps_unittest.py:
+        (TestCheckPatchRelevance.test_non_relevant_patch):
+
 2020-04-08  Aakash Jain  <aakash_jain@apple.com>