Changeset 259943 in webkit

Timestamp:

Apr 12, 2020 2:27:40 AM (4 years ago)

Author:

Carlos Garcia Campos

Message:

[GTK] Page is not drawn with PSON, hardware acceleration and address typed in URL bar
​https://bugs.webkit.org/show_bug.cgi?id=208091

Reviewed by Michael Catanzaro.

This happens only when accelerated compositing mode policy is set to always. In this case, the
bindSurfaceToWebPage wayland message is received before the WebPageProxy has updated the web page identifier. We
should always check if there's a provisional page and get its web page identifier.

• UIProcess/gtk/WaylandCompositor.cpp:

(WebKit::WaylandCompositor::bindSurfaceToWebPage):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/gtk/WaylandCompositor.cpp (modified) (2 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-04-12  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK] Page is not drawn with PSON, hardware acceleration and address typed in URL bar
+        https://bugs.webkit.org/show_bug.cgi?id=208091
+
+        Reviewed by Michael Catanzaro.
+
+        This happens only when accelerated compositing mode policy is set to always. In this case, the
+        bindSurfaceToWebPage wayland message is received before the WebPageProxy has updated the web page identifier. We
+        should always check if there's a provisional page and get its web page identifier.
+
+        * UIProcess/gtk/WaylandCompositor.cpp:
+        (WebKit::WaylandCompositor::bindSurfaceToWebPage):
+
 2020-04-12  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebKit/UIProcess/gtk/WaylandCompositor.cpp

@@ -29 +29 @@
 #if PLATFORM(WAYLAND) && USE(EGL) && !USE(WPE_RENDERER)
 
+#include "ProvisionalPageProxy.h"
 #include "WebKitWaylandServerProtocol.h"
 #include <EGL/egl.h>
@@ -559 +560 @@
     WebPageProxy* webPage = nullptr;
     for (auto* page : m_pageMap.keys()) {
-        if (page->webPageID() == pageID) {
+        auto* provisionalPage = page->provisionalPageProxy();
+        auto webPageID = provisionalPage ? provisionalPage->webPageID() : page->webPageID();
+        if (webPageID == pageID) {
             webPage = page;
             break;