Changeset 260309 in webkit


Ignore:
Timestamp:
Apr 18, 2020 7:19:47 AM (4 years ago)
Author:
commit-queue@webkit.org
Message:

REGRESSION(r260246): It broke build on MIPS32
https://bugs.webkit.org/show_bug.cgi?id=210665

Patch by Angelos Oikonomopoulos <Angelos Oikonomopoulos> on 2020-04-18
Reviewed by Aakash Jain.

The mnemonic for 'store halfword' is 'sh', not 'shv'. This appears to
be a typo in a path that was never exercised.

Exposed by r260246; riscLowerMisplacedAddresses now calls into
riscAsRegisters with an 'h' suffix, which results in a 'storeh'
instruction. The storeh is then lowered to the non-existent 'shv'.

  • offlineasm/mips.rb:
Location:
trunk/Source/JavaScriptCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/JavaScriptCore/ChangeLog

    r260297 r260309  
     12020-04-18  Angelos Oikonomopoulos  <angelos@igalia.com>
     2
     3        REGRESSION(r260246): It broke build on MIPS32
     4        https://bugs.webkit.org/show_bug.cgi?id=210665
     5
     6        Reviewed by Aakash Jain.
     7
     8        The mnemonic for 'store halfword' is 'sh', not 'shv'. This appears to
     9        be a typo in a path that was never exercised.
     10
     11        Exposed by r260246; riscLowerMisplacedAddresses now calls into
     12        riscAsRegisters with an 'h' suffix, which results in a 'storeh'
     13        instruction. The storeh is then lowered to the non-existent 'shv'.
     14
     15        * offlineasm/mips.rb:
     16
    1172020-04-17  Commit Queue  <commit-queue@webkit.org>
    218
  • trunk/Source/JavaScriptCore/offlineasm/mips.rb

    r257466 r260309  
    905905            $asm.puts "lh #{mipsFlippedOperands(operands)}"
    906906        when "storeh"
    907             $asm.puts "shv #{mipsOperands(operands)}"
     907            $asm.puts "sh #{mipsOperands(operands)}"
    908908        when "loadd"
    909909            $asm.puts "ldc1 #{mipsFlippedOperands(operands)}"
Note: See TracChangeset for help on using the changeset viewer.