Changeset 260384 in webkit

Timestamp:

Apr 20, 2020 12:11:46 PM (4 years ago)

Author:

ysuzuki@apple.com

Message:

[JSC] Skip test262 for non-safe-integer range BigIntConstructor
​https://bugs.webkit.org/show_bug.cgi?id=210749

Reviewed by Keith Miller.

JSTests:

We skip test262 test/built-ins/BigInt/constructor-integer.js for now. As it is shown in old test262 JSTests/test262/expectations.yaml,
this test was failing before BigInt flag is enabled. And new BigInt patch changes error message while we are failing in the same way.
While we implemented BigInt, this test is based on spec change introduced[1], and we are not implementing this. So we mark it skipped,
as it is skipped before BigInt is enabled.

[1]: ​https://github.com/tc39/proposal-bigint/pull/138

• test262/config.yaml:

Source/JavaScriptCore:

• runtime/BigIntConstructor.cpp:

(JSC::callBigIntConstructor):

Location:

trunk

Files:

• JSTests/ChangeLog (modified) (1 diff)
• JSTests/test262/config.yaml (modified) (1 diff)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/runtime/BigIntConstructor.cpp (modified) (1 diff)

trunk/JSTests/ChangeLog

@@ +1 @@
+2020-04-20  Yusuke Suzuki  <ysuzuki@apple.com>
+
+        [JSC] Skip test262 for non-safe-integer range BigIntConstructor
+        https://bugs.webkit.org/show_bug.cgi?id=210749
+
+        Reviewed by Keith Miller.
+
+        We skip test262 test/built-ins/BigInt/constructor-integer.js for now. As it is shown in old test262 JSTests/test262/expectations.yaml,
+        this test was failing before BigInt flag is enabled. And new BigInt patch changes error message while we are failing in the same way.
+        While we implemented BigInt, this test is based on spec change introduced[1], and we are not implementing this. So we mark it skipped,
+        as it is skipped before BigInt is enabled.
+
+        [1]: https://github.com/tc39/proposal-bigint/pull/138
+
+        * test262/config.yaml:
+
 2020-04-20  Keith Miller  <keith_miller@apple.com>
 

trunk/JSTests/test262/config.yaml

@@ -158 +158 @@
     - test/intl402/RelativeTimeFormat/prototype/format/en-us-numeric-auto.js
     - test/intl402/RelativeTimeFormat/prototype/formatToParts/en-us-numeric-auto.js
+
+    # Spec is changed. https://github.com/tc39/proposal-bigint/pull/138
+    - test/built-ins/BigInt/constructor-integer.js

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2020-04-20  Yusuke Suzuki  <ysuzuki@apple.com>
+
+        [JSC] Skip test262 for non-safe-integer range BigIntConstructor
+        https://bugs.webkit.org/show_bug.cgi?id=210749
+
+        Reviewed by Keith Miller.
+
+        * runtime/BigIntConstructor.cpp:
+        (JSC::callBigIntConstructor):
+
 2020-04-20  Keith Miller  <keith_miller@apple.com>
 

trunk/Source/JavaScriptCore/runtime/BigIntConstructor.cpp

@@ -121 +121 @@
 
     if (primitive.isDouble()) {
+        // FIXME: Accept larger integers than safe-integers.
+        // https://bugs.webkit.org/show_bug.cgi?id=210755
         double number = primitive.asDouble();
         if (trunc(number) != number || std::abs(number) > maxSafeInteger())