Changeset 260471 in webkit

Timestamp:

Apr 21, 2020 4:00:32 PM (4 years ago)

Author:

Darin Adler

Message:

[Mac] Enable color well tests on modern WebKit
​https://bugs.webkit.org/show_bug.cgi?id=210810

Reviewed by Alexey Proskuryakov.

When running tests I was informed of "unexpected passing" for the
test fast/css/pseudo-visited-background-color-on-input.html.
After doing some research, I found that we have tests of color well
that are still disabled on Mac even though we have implemented it
now, just not for legacy WebKit.

Looking at history I see these tests have been passing consistently
on bots. So changed their expectations to Pass, and also un-skipped
some other tests of the same feature that passed for me locally.

• platform/mac-highsierra-wk1/*: Removed.
• platform/mac-highsierra/*: Removed.

• platform/mac-wk1/TestExpectations: Moved expectations here for tests

that we should not run because we don't have color wells enabled.

• platform/mac-wk2/TestExpectations: Moved expectations here

for color well tests that still don't work in modern WebKit because we
need more support for dragging tests.

• platform/mac/TestExpectations: Moved the expections *from* here.

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• platform/mac-highsierra (deleted)
• platform/mac-highsierra-wk1 (deleted)
• platform/mac-wk1/TestExpectations (modified) (1 diff)
• platform/mac-wk2/TestExpectations (modified) (1 diff)
• platform/mac/TestExpectations (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2020-04-21  Darin Adler  <darin@apple.com>
+
+        [Mac] Enable color well tests on modern WebKit
+        https://bugs.webkit.org/show_bug.cgi?id=210810
+
+        Reviewed by Alexey Proskuryakov.
+
+        When running tests I was informed of "unexpected passing" for the
+        test fast/css/pseudo-visited-background-color-on-input.html.
+        After doing some research, I found that we have tests of color well
+        that are still disabled on Mac even though we have implemented it
+        now, just not for legacy WebKit.
+
+        Looking at history I see these tests have been passing consistently
+        on bots. So changed their expectations to Pass, and also un-skipped
+        some other tests of the same feature that passed for me locally.
+
+        * platform/mac-highsierra-wk1/*: Removed.
+        * platform/mac-highsierra/*: Removed.
+
+        * platform/mac-wk1/TestExpectations: Moved expectations here for tests
+        that we should not run because we don't have color wells enabled.
+
+        * platform/mac-wk2/TestExpectations: Moved expectations here
+        for color well tests that still don't work in modern WebKit because we
+        need more support for dragging tests.
+
+        * platform/mac/TestExpectations: Moved the expections *from* here.
+
 2020-04-21  Simon Fraser  <simon.fraser@apple.com>
 

trunk/LayoutTests/platform/mac-wk1/TestExpectations

@@ -186 +186 @@
 # testRunner.queueLoad() does not support loading data URLs in Mac WK1
 http/tests/security/contentSecurityPolicy/navigate-self-to-data-url.html [ Skip ]
+
+# Color well is turned off.
+accessibility/color-well.html [ Skip ]
+editing/pasteboard/drag-and-drop-color-input-events.html [ Skip ]
+editing/pasteboard/drag-and-drop-color-input.html [ Skip ]
+fast/css/pseudo-visited-background-color-on-input.html [ ImageOnlyFailure ]
+fast/css/read-only-read-write-input-basics.html [ ImageOnlyFailure ]
+fast/forms/color [ Skip ]
+imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/color.html [ Skip ]
 
 #//////////////////////////////////////////////////////////////////////////////////////////

trunk/LayoutTests/platform/mac-wk2/TestExpectations

@@ -220 +220 @@
 # [WK2] [Mac] Support drag in mouse events for WebKit2 EventSender
 # <https://bugs.webkit.org/show_bug.cgi?id=68552>
+editing/pasteboard/drag-and-drop-color-input-events.html [ Skip ]
+editing/pasteboard/drag-and-drop-color-input.html [ Skip ]
 editing/selection/select-across-readonly-input-2.html
 editing/selection/select-across-readonly-input-3.html

trunk/LayoutTests/platform/mac/TestExpectations

@@ -1577 +1577 @@
 webkit.org/b/198543 imported/w3c/web-platform-tests/css/css-text/line-break/line-break-anywhere-001.html [ ImageOnlyFailure ]
 
-
-# Color Well is turned off
-accessibility/color-well.html [ Skip ]
-fast/forms/color [ Skip ]
-editing/pasteboard/drag-and-drop-color-input.html [ Skip ]
-editing/pasteboard/drag-and-drop-color-input-events.html [ Skip ]
-imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/color.html [ Skip ]
-fast/css/read-only-read-write-input-basics.html [ ImageOnlyFailure ]
-fast/css/pseudo-visited-background-color-on-input.html [ ImageOnlyFailure ]
-
 webkit.org/b/187393 imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-origin.sub.html [ Pass Failure ]