Changeset 260474 in webkit

Timestamp:

Apr 21, 2020 5:03:54 PM (4 years ago)

Author:

jer.noble@apple.com

Message:

PiP buttons shows up in element fullscreen when PiP is disabled in WKWebViewConfiguration
​https://bugs.webkit.org/show_bug.cgi?id=210813

Reviewed by Eric Carlson.

Not currently testable; entering fullscreen never completes in the iOS TestWebKitAPI app
because that process is not a UI Application.

• UIProcess/ios/fullscreen/WKFullScreenViewController.mm:

(-[WKFullScreenViewController videoControlsManagerDidChange]):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/ios/fullscreen/WKFullScreenViewController.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-04-21  Jer Noble  <jer.noble@apple.com>
+
+        PiP buttons shows up in element fullscreen when PiP is disabled in WKWebViewConfiguration
+        https://bugs.webkit.org/show_bug.cgi?id=210813
+
+        Reviewed by Eric Carlson.
+
+        Not currently testable; entering fullscreen never completes in the iOS TestWebKitAPI app
+        because that process is not a UI Application.
+
+        * UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
+        (-[WKFullScreenViewController videoControlsManagerDidChange]):
+
 2020-04-21  Brent Fulgham  <bfulgham@apple.com>
 

trunk/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm

@@ -266 +266 @@
     WebCore::PlaybackSessionModel* playbackSessionModel = playbackSessionInterface ? playbackSessionInterface->playbackSessionModel() : nullptr;
     self.playing = playbackSessionModel ? playbackSessionModel->isPlaying() : NO;
-    [_pipButton setHidden:!playbackSessionModel];
+    [_pipButton setHidden:!playbackSessionModel || !playbackSessionModel->isPictureInPictureSupported()];
 }