Changeset 260481 in webkit


Ignore:
Timestamp:
Apr 21, 2020 6:27:49 PM (4 years ago)
Author:
keith_miller@apple.com
Message:

JSC's options should be case insensitive
https://bugs.webkit.org/show_bug.cgi?id=210834

Reviewed by Yusuke Suzuki.

  • runtime/Options.cpp:

(JSC::Options::setOptionWithoutAlias):
(JSC::Options::setAliasedOption):

  • runtime/OptionsList.h:
Location:
trunk/Source/JavaScriptCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/JavaScriptCore/ChangeLog

    r260447 r260481  
     12020-04-21  Keith Miller  <keith_miller@apple.com>
     2
     3        JSC's options should be case insensitive
     4        https://bugs.webkit.org/show_bug.cgi?id=210834
     5
     6        Reviewed by Yusuke Suzuki.
     7
     8        * runtime/Options.cpp:
     9        (JSC::Options::setOptionWithoutAlias):
     10        (JSC::Options::setAliasedOption):
     11        * runtime/OptionsList.h:
     12
    1132020-04-21  Alexey Shvayka  <shvaikalesh@gmail.com>
    214
  • trunk/Source/JavaScriptCore/runtime/Options.cpp

    r259711 r260481  
    774774#define SET_OPTION_IF_MATCH(type_, name_, defaultValue_, availability_, description_) \
    775775    if (strlen(#name_) == static_cast<size_t>(equalStr - arg)      \
    776         && !strncmp(arg, #name_, equalStr - arg)) {                \
    777         if (Availability::availability_ != Availability::Normal     \
     776        && !strncasecmp(arg, #name_, equalStr - arg)) {            \
     777        if (Availability::availability_ != Availability::Normal    \
    778778            && !isAvailable(name_##ID, Availability::availability_)) \
    779779            return false;                                          \
     
    818818#define FOR_EACH_OPTION(aliasedName_, unaliasedName_, equivalence) \
    819819    if (strlen(#aliasedName_) == static_cast<size_t>(equalStr - arg)    \
    820         && !strncmp(arg, #aliasedName_, equalStr - arg)) {              \
     820        && !strncasecmp(arg, #aliasedName_, equalStr - arg)) {          \
    821821        String unaliasedOption(#unaliasedName_);                        \
    822822        if (equivalence == SameOption)                                  \
     
    829829            unaliasedOption = unaliasedOption + "=" + invertedValueStr; \
    830830        }                                                               \
    831         return setOptionWithoutAlias(unaliasedOption.utf8().data());   \
     831        return setOptionWithoutAlias(unaliasedOption.utf8().data());    \
    832832    }
    833833
  • trunk/Source/JavaScriptCore/runtime/OptionsList.h

    r260349 r260481  
    542542    v(enableDollarVM, useDollarVM, SameOption) \
    543543    v(enableWebAssembly, useWebAssembly, SameOption) \
    544     v(verboseDFGByteCodeParsing, verboseDFGBytecodeParsing, SameOption) \
    545544    v(maximumOptimizationCandidateInstructionCount, maximumOptimizationCandidateBytecodeCost, SameOption) \
    546545    v(maximumFunctionForCallInlineCandidateInstructionCount, maximumFunctionForCallInlineCandidateBytecodeCost, SameOption) \
Note: See TracChangeset for help on using the changeset viewer.