Changeset 260488 in webkit


Ignore:
Timestamp:
Apr 21, 2020 7:23:06 PM (4 years ago)
Author:
Peng Liu
Message:

platform/mac/media/audio-session-category-audio-autoplay.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=210826

Reviewed by Jer Noble.

For WebKitLegacy, AudioSession::setCategory() needs to set the category when
m_routingArbitrationClient is nullptr. This patch also fixes an error regarding
setupArbitrationOngoing.

  • platform/audio/mac/AudioSessionMac.mm:

(WebCore::AudioSession::setCategory):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r260486 r260488  
     12020-04-21  Peng Liu  <peng.liu6@apple.com>
     2
     3        platform/mac/media/audio-session-category-audio-autoplay.html is timing out
     4        https://bugs.webkit.org/show_bug.cgi?id=210826
     5
     6        Reviewed by Jer Noble.
     7
     8        For WebKitLegacy, AudioSession::setCategory() needs to set the category when
     9        m_routingArbitrationClient is nullptr. This patch also fixes an error regarding
     10        setupArbitrationOngoing.
     11
     12        * platform/audio/mac/AudioSessionMac.mm:
     13        (WebCore::AudioSession::setCategory):
     14
    1152020-04-21  Peng Liu  <peng.liu6@apple.com>
    216
  • trunk/Source/WebCore/platform/audio/mac/AudioSessionMac.mm

    r260172 r260488  
    9797    }
    9898
     99    m_private->category = category;
     100    if (m_private->category == None)
     101        return;
     102
    99103    if (!m_routingArbitrationClient)
    100104        return;
     
    105109    }
    106110
    107     m_private->category = category;
    108     if (m_private->category == None)
    109         return;
    110 
    111111    using RoutingArbitrationError = AudioSessionRoutingArbitrationClient::RoutingArbitrationError;
    112112    using DefaultRouteChanged = AudioSessionRoutingArbitrationClient::DefaultRouteChanged;
    113113
     114    m_private->setupArbitrationOngoing = true;
    114115    m_routingArbitrationClient->beginRoutingArbitrationWithCategory(m_private->category, [this] (RoutingArbitrationError error, DefaultRouteChanged defaultRouteChanged) {
    115116        m_private->setupArbitrationOngoing = false;
Note: See TracChangeset for help on using the changeset viewer.